-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 13 pull requests #40651
Rollup of 13 pull requests #40651
Commits on Mar 11, 2017
-
Point to let when modifying field of immutable variable
Point at the immutable local variable when trying to modify one of its fields. Given a file: ```rust struct Foo { pub v: Vec<String> } fn main() { let f = Foo { v: Vec::new() }; f.v.push("cat".to_string()); } ``` present the following output: ``` error: cannot borrow immutable field `f.v` as mutable --> file.rs:7:13 | 6 | let f = Foo { v: Vec::new() }; | - this should be `mut` 7 | f.v.push("cat".to_string()); | ^^^ error: aborting due to previous error ```
Configuration menu - View commit details
-
Copy full SHA for 6ba494b - Browse repository at this point
Copy the full SHA 6ba494bView commit details
Commits on Mar 12, 2017
-
Change label to "consider changing this to
mut f
"Change the wording of mutable borrow on immutable binding from "this should be `mut`" to "consider changing this to `mut f`".
Configuration menu - View commit details
-
Copy full SHA for 38b5b29 - Browse repository at this point
Copy the full SHA 38b5b29View commit details
Commits on Mar 14, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 9ac628d - Browse repository at this point
Copy the full SHA 9ac628dView commit details -
Add feature toggle for rvalue-static-promotion RFC
See rust-lang/rfcs#1414. Updates rust-lang#38865.
Configuration menu - View commit details
-
Copy full SHA for b43c744 - Browse repository at this point
Copy the full SHA b43c744View commit details -
It does not seem valuable to always evaluate the right-hand side here.
Configuration menu - View commit details
-
Copy full SHA for 20c0f32 - Browse repository at this point
Copy the full SHA 20c0f32View commit details -
Configuration menu - View commit details
-
Copy full SHA for f06b049 - Browse repository at this point
Copy the full SHA f06b049View commit details
Commits on Mar 15, 2017
-
Configuration menu - View commit details
-
Copy full SHA for befeb04 - Browse repository at this point
Copy the full SHA befeb04View commit details
Commits on Mar 16, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 9b89274 - Browse repository at this point
Copy the full SHA 9b89274View commit details -
Configuration menu - View commit details
-
Copy full SHA for 910532e - Browse repository at this point
Copy the full SHA 910532eView commit details
Commits on Mar 17, 2017
-
documented order of conversion between u32 an ipv4addr
z1mvader committedMar 17, 2017 Configuration menu - View commit details
-
Copy full SHA for 50cede0 - Browse repository at this point
Copy the full SHA 50cede0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 963d4df - Browse repository at this point
Copy the full SHA 963d4dfView commit details -
This seems to match other uses of "be accessed" in the document.
Configuration menu - View commit details
-
Copy full SHA for ec8ecf4 - Browse repository at this point
Copy the full SHA ec8ecf4View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb96ade - Browse repository at this point
Copy the full SHA cb96adeView commit details
Commits on Mar 18, 2017
-
Fix a spelling error in HashMap documentation, and slightly reword it…
… to be more precise.
Configuration menu - View commit details
-
Copy full SHA for 2976ddb - Browse repository at this point
Copy the full SHA 2976ddbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8eaac08 - Browse repository at this point
Copy the full SHA 8eaac08View commit details
Commits on Mar 19, 2017
-
Add mention of None as possible return. Closes rust-lang#40435.
Russell Mackenzie committedMar 19, 2017 Configuration menu - View commit details
-
Copy full SHA for b77d31a - Browse repository at this point
Copy the full SHA b77d31aView commit details -
The name of the variable used in the example is `path`, not `os_str`.
Configuration menu - View commit details
-
Copy full SHA for 7add53e - Browse repository at this point
Copy the full SHA 7add53eView commit details -
Rollup merge of rust-lang#40441 - tschottdorf:promotable-rfc, r=eddyb
Add feature gate for rvalue-static-promotion Probably needs more tests (which ones?) and there may be other things that need to be done. Also not sure whether the version that introduces the flag is really `1.15.1`. See rust-lang/rfcs#1414. Updates rust-lang#38865.
Configuration menu - View commit details
-
Copy full SHA for 7b686ce - Browse repository at this point
Copy the full SHA 7b686ceView commit details -
Rollup merge of rust-lang#40445 - estebank:issue-18150, r=jonathandtu…
…rner Point to let when modifying field of immutable variable Point at the immutable local variable when trying to modify one of its fields. Given a file: ```rust struct Foo { pub v: Vec<String> } fn main() { let f = Foo { v: Vec::new() }; f.v.push("cat".to_string()); } ``` present the following output: ``` error: cannot borrow immutable field `f.v` as mutable --> file.rs:7:13 | 6 | let f = Foo { v: Vec::new() }; | - this should be `mut` 7 | f.v.push("cat".to_string()); | ^^^ error: aborting due to previous error ``` Fix rust-lang#27593.
Configuration menu - View commit details
-
Copy full SHA for 9032cea - Browse repository at this point
Copy the full SHA 9032ceaView commit details -
Rollup merge of rust-lang#40562 - mbrubeck:bootstrap, r=alexcrichton
Remove unused param from bootstrap::clean::rm_rf None
Configuration menu - View commit details
-
Copy full SHA for 8287d0d - Browse repository at this point
Copy the full SHA 8287d0dView commit details -
Rollup merge of rust-lang#40564 - GuillaumeGomez:rustdoc-const, r=fre…
…wsxcv Fix const not displayed in rustdoc Fixes rust-lang#40331. r? @rust-lang/docs
Configuration menu - View commit details
-
Copy full SHA for a04c7de - Browse repository at this point
Copy the full SHA a04c7deView commit details -
Rollup merge of rust-lang#40583 - jseyfried:fix_include_macro_regress…
…ion, r=nrc macros: fix regression with `include!()` Fixes rust-lang#40469, a regression when `include!()`ing a `macro_rules!` containing `$crate`. r? @nrc
Configuration menu - View commit details
-
Copy full SHA for c949f49 - Browse repository at this point
Copy the full SHA c949f49View commit details -
Rollup merge of rust-lang#40588 - topecongiro:add-missing-tests, r=al…
…excrichton Add a test for issue 34571 Closes rust-lang#34571.
Configuration menu - View commit details
-
Copy full SHA for 03a30b5 - Browse repository at this point
Copy the full SHA 03a30b5View commit details -
Rollup merge of rust-lang#40589 - topecongiro:floating-point-literal,…
… r=nagisa Parse 0e+10 as a valid floating-point literal Fixes issue rust-lang#40408.
Configuration menu - View commit details
-
Copy full SHA for f2290da - Browse repository at this point
Copy the full SHA f2290daView commit details -
Rollup merge of rust-lang#40590 - z1mvader:master, r=steveklabnik
documented order of conversion between u32 an ipv4addr This fixes rust-lang#40118
Configuration menu - View commit details
-
Copy full SHA for d74c528 - Browse repository at this point
Copy the full SHA d74c528View commit details -
Rollup merge of rust-lang#40603 - QuietMisdreavus:slice-ptr-docs, r=G…
…uillaumeGomez minor wording tweak to slice::{as_ptr, as_mut_ptr} Per rust-lang#37334, the slice-as-pointer methods mentioned that "modifying the slice may cause its buffer to be reallocated", when in fact modifying the *slice* itself would cause no such change. (It is a borrow, after all!) This is a tweak to the wording of that line to stress it's the *collection* that could cause the buffer to be reallocated. r? @steveklabnik
Configuration menu - View commit details
-
Copy full SHA for 969e625 - Browse repository at this point
Copy the full SHA 969e625View commit details -
Rollup merge of rust-lang#40611 - ScottAbbey:patch-1, r=GuillaumeGomez
Fix typo in mutex.rs docs This seems to match other uses of "be accessed" in the document.
Configuration menu - View commit details
-
Copy full SHA for d8c8e01 - Browse repository at this point
Copy the full SHA d8c8e01View commit details -
Rollup merge of rust-lang#40621 - jswalden:dependant-spelling-fix, r=…
…sfackler Fix a spelling error in HashMap documentation, and slightly reword surrounding text for precision Noticed while reading docs just now. It's possible that the prior wording *meant* to state that the seed's randomness depends on the exact instant that the system RNG was created, I guess. But unless there's an API guarantee that this is the case, the wording seems over-precise. Is there a formal API guarantee that would forbid, say, the system RNG from generating all output using the Intel RDRAND instruction? I don't think the quality of output in that case would depend on when the RNG was created. Yet it seems to me like it could well be a valid source of randomness when computing the initial seed. For that reason, tying the randomness of the seed, to the quality of the RNG's output *at the precise instant the seed is computed*, seems less confining. That instantaneous quality level could be determined by the quality at the instant the RNG was created -- but instantaneous quality need not be low for that precise reason.
Configuration menu - View commit details
-
Copy full SHA for 9e11ecb - Browse repository at this point
Copy the full SHA 9e11ecbView commit details -
Rollup merge of rust-lang#40646 - russmack:issue-40435-mention-none, …
…r=frewsxcv Add mention of None as possible return. Closes rust-lang#40435. This commit adds a small mention to some methods that None is returned when the slice is empty.
Configuration menu - View commit details
-
Copy full SHA for 35cf2f9 - Browse repository at this point
Copy the full SHA 35cf2f9View commit details -
Rollup merge of rust-lang#40648 - s3rvac:fix-path-docs-typo, r=frewsxcv
Fix a typo in path.rs docs The name of the variable used in the example is `path`, not `os_str`.
Configuration menu - View commit details
-
Copy full SHA for 94e346b - Browse repository at this point
Copy the full SHA 94e346bView commit details