Convert MIR BasicBlocks to ExtendedBasicBlocks #40700
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb |
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
☔ The latest upstream changes (presumably #40693) made this pull request unmergeable. Please resolve the merge conflicts. |
Mark-Simulacrum
force-pushed
the
extbb-2
branch
from
a2e1ba1
to
04f9393
Compare
|
☔ The latest upstream changes (presumably #40806) made this pull request unmergeable. Please resolve the merge conflicts. |
Mark-Simulacrum
force-pushed
the
extbb-2
branch
3 times, most recently
from
1106eff
to
1448131
Compare
This introduces no functional changes, but is in preparation for adding extended basic blocks to MIR.
* Updates Drop, Assert, and Call TerminatorKinds to do this. * Changes various code in these terminators to have more uniform completions and replaced non-end-of-block llblock and funclet_br with the code that they'd execute.
This removes the unreachable_block cache, since we no longer utilize it.
Mark-Simulacrum
force-pushed
the
extbb-2
branch
from
1448131
to
49b486b
Compare
Mark-Simulacrum
force-pushed
the
extbb-2
branch
from
a383adc
to
ff12d78
Compare
This reverts commit 8cee04a. It turns out that DropElaboration may need the CallGuards pass, even if trans doesn't.
|
☔ The latest upstream changes (presumably #40597) made this pull request unmergeable. Please resolve the merge conflicts. |
Mark-Simulacrum
force-pushed
the
extbb-2
branch
2 times, most recently
from
3f23d75
to
15d5bde
Compare
|
I'm going to close this out for now since it's relatively blocked on me finding a good chunk of time to work on uninterrupted, but if anyone wants to steal my branch, feel free. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a work in progress, will write up more detailed summary later, but see #39685.