Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store a copy of the Issue32230 info within TypeError #40836

Merged
merged 1 commit into from
Mar 29, 2017

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented Mar 26, 2017

The data can't be looked up from the region variable directly, because
the region variable might have been destroyed at the end of a snapshot.

Fixes #40000.
Fixes #40743.

beta-nominating because regression.
r? @nikomatsakis

@arielb1 arielb1 added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 26, 2017
The data can't be looked up from the region variable directly, because
the region variable might have been destroyed at the end of a snapshot.

Fixes rust-lang#40000.
Fixes rust-lang#40743.
@nikomatsakis
Copy link
Contributor

@bors r+ p=1

  • Giving high priority because of beta nomination.

@bors
Copy link
Contributor

bors commented Mar 27, 2017

📌 Commit 7e0f7a5 has been approved by nikomatsakis

@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 27, 2017
@nikomatsakis
Copy link
Contributor

cc @rust-lang/compiler

Accepting for beta. Small patch, fixes regression (ICE).

@bors
Copy link
Contributor

bors commented Mar 29, 2017

⌛ Testing commit 7e0f7a5 with merge 1b0ecec...

@frewsxcv
Copy link
Member

retrying to prioritize rollup which includes this pr

@bors r-

@frewsxcv
Copy link
Member

welp, meant to retry

@bors r=nikomatsakis p=1

@bors
Copy link
Contributor

bors commented Mar 29, 2017

📌 Commit 7e0f7a5 has been approved by nikomatsakis

@frewsxcv
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Mar 29, 2017

⌛ Testing commit 7e0f7a5 with merge 10b1739...

bors added a commit that referenced this pull request Mar 29, 2017
store a copy of the Issue32230 info within TypeError

The data can't be looked up from the region variable directly, because
the region variable might have been destroyed at the end of a snapshot.

Fixes #40000.
Fixes #40743.

beta-nominating because regression.
r? @nikomatsakis
@bors
Copy link
Contributor

bors commented Mar 29, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 10b1739 to master...

@bors bors merged commit 7e0f7a5 into rust-lang:master Mar 29, 2017
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 1, 2017
bors added a commit that referenced this pull request Apr 1, 2017
Backport PRs to beta

Backport of

* #40967
* #40836
* #40779
* #40888

Also includes a cargo submodule update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants