Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update various book modules #40864

Merged
merged 1 commit into from
Mar 29, 2017
Merged

Conversation

steveklabnik
Copy link
Member

This includes an important fix for rustc contributors in
rust-lang/book#571

I'm going to update the other ones as well here while we're at it; no
need to spam PRs.

r? @nrc

@nrc
Copy link
Member

nrc commented Mar 27, 2017

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 27, 2017

📌 Commit c4dc439 has been approved by nrc

@steveklabnik
Copy link
Member Author

@bors: r-

sorry, this fails tidy. fixing.

This includes an important fix for rustc contributors in
rust-lang/book#571

I'm going to update the other ones as well here while we're at it; no
need to spam PRs.
@steveklabnik
Copy link
Member Author

@bors: r=nrc

sorry about that!

@bors
Copy link
Contributor

bors commented Mar 27, 2017

📌 Commit 434e601 has been approved by nrc

@steveklabnik
Copy link
Member Author

@bors: p=1

I'm giving this one a priority because it's gonna mess with other contributors until it lands; I don't want people to have submodule pain.

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 29, 2017
Update various book modules

This includes an important fix for rustc contributors in
rust-lang/book#571

I'm going to update the other ones as well here while we're at it; no
need to spam PRs.

r? @nrc
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 29, 2017
Update various book modules

This includes an important fix for rustc contributors in
rust-lang/book#571

I'm going to update the other ones as well here while we're at it; no
need to spam PRs.

r? @nrc
bors added a commit that referenced this pull request Mar 29, 2017
Rollup of 5 pull requests

- Successful merges: #40682, #40731, #40783, #40838, #40864
- Failed merges:
@bors
Copy link
Contributor

bors commented Mar 29, 2017

⌛ Testing commit 434e601 with merge 4465f22...

@bors bors merged commit 434e601 into rust-lang:master Mar 29, 2017
@steveklabnik steveklabnik deleted the update-submodules branch March 29, 2017 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants