Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify str Structs descriptions #40935

Merged
merged 8 commits into from
Apr 1, 2017

Conversation

donniebishop
Copy link
Contributor

References #29375. Modified descriptions of multiple structs to be more in line with structs found under std::iter, such as Chain and Enumerate

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@donniebishop donniebishop changed the title Str boilerplate docs Modify str Structs descriptions Mar 30, 2017
Original headline of SplitWhitespace's description is more descriptive as to what it contains and iterates over.
Copy link
Member

@steveklabnik steveklabnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tiny thing and then this is good to go!

/// For use with the `std::iter` module.
/// [`u16`]: ../../std/primitive.u16.html
///
/// This struct is created by the [`encode_utf16()`] method on [`str`].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't include the ()s when referencing methods; could you change that everywhere please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can diddly do

@steveklabnik steveklabnik mentioned this pull request Mar 30, 2017
11 tasks
@alexcrichton
Copy link
Member

r? @steveklabnik

@steveklabnik
Copy link
Member

steveklabnik commented Mar 31, 2017

@bors: r+ rollup

Thanks a ton!

@bors
Copy link
Contributor

bors commented Mar 31, 2017

📌 Commit 3b39621 has been approved by steveklabnik

@bors
Copy link
Contributor

bors commented Mar 31, 2017

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Mar 31, 2017

📌 Commit 3b39621 has been approved by steveklabnik

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 31, 2017
…r=steveklabnik

Modify str Structs descriptions

References rust-lang#29375. Modified descriptions of multiple structs to be more in line with structs found under [`std::iter`](https://doc.rust-lang.org/std/iter/#structs), such as [`Chain`](https://doc.rust-lang.org/std/iter/struct.Chain.html) and [`Enumerate`](https://doc.rust-lang.org/std/iter/struct.Enumerate.html)
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 31, 2017
…r=steveklabnik

Modify str Structs descriptions

References rust-lang#29375. Modified descriptions of multiple structs to be more in line with structs found under [`std::iter`](https://doc.rust-lang.org/std/iter/#structs), such as [`Chain`](https://doc.rust-lang.org/std/iter/struct.Chain.html) and [`Enumerate`](https://doc.rust-lang.org/std/iter/struct.Enumerate.html)
bors added a commit that referenced this pull request Mar 31, 2017
Rollup of 6 pull requests

- Successful merges: #40703, #40728, #40763, #40871, #40935, #40947
- Failed merges:
@bors bors merged commit 3b39621 into rust-lang:master Apr 1, 2017
@donniebishop donniebishop deleted the str_boilerplate_docs branch April 1, 2017 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants