-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std: Back out backtrace pruning logic #41364
Conversation
It was discovered rust-lang#40264 that this backtrace pruning logic is a little too aggressive, so while we figure how out to handle rust-lang#40264 this commit backs out the changes to prune frames. Note that other cosmetic changes, such as better path printing and such remain.
r? @BurntSushi (rust_highfive has picked a reviewer for you, use r? to override) |
@bors r+ |
📌 Commit e46a8bd has been approved by |
…r=petrochenkov std: Back out backtrace pruning logic It was discovered rust-lang#40264 that this backtrace pruning logic is a little too aggressive, so while we figure how out to handle rust-lang#40264 this commit backs out the changes to prune frames. Note that other cosmetic changes, such as better path printing and such remain.
…r=petrochenkov std: Back out backtrace pruning logic It was discovered rust-lang#40264 that this backtrace pruning logic is a little too aggressive, so while we figure how out to handle rust-lang#40264 this commit backs out the changes to prune frames. Note that other cosmetic changes, such as better path printing and such remain.
This might've unintentionally removed the message that shows that you can switch to a full backtrace with "RUST_BACKTRACE=full", because the logic for it checks whether frames got omitted: rust/src/libstd/sys_common/backtrace.rs Line 74 in 9f2abad
So this message never shows up. |
@CryZe that's somewhat intentional, the |
Ah okay, thanks for clarifying :) |
It was discovered #40264 that this backtrace pruning logic is a little too
aggressive, so while we figure how out to handle #40264 this commit backs out
the changes to prune frames. Note that other cosmetic changes, such as better
path printing and such remain.