Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Back out backtrace pruning logic #41364

Merged
merged 1 commit into from
Apr 18, 2017

Conversation

alexcrichton
Copy link
Member

It was discovered #40264 that this backtrace pruning logic is a little too
aggressive, so while we figure how out to handle #40264 this commit backs out
the changes to prune frames. Note that other cosmetic changes, such as better
path printing and such remain.

It was discovered rust-lang#40264 that this backtrace pruning logic is a little too
aggressive, so while we figure how out to handle rust-lang#40264 this commit backs out
the changes to prune frames. Note that other cosmetic changes, such as better
path printing and such remain.
@rust-highfive
Copy link
Collaborator

r? @BurntSushi

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

#40684 was the beta backport. This hasn't been applied to master yet but it looks like #40264 may go past the next cycle so I figured I'd send this to master as well.

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Apr 18, 2017

📌 Commit e46a8bd has been approved by petrochenkov

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 18, 2017
…r=petrochenkov

std: Back out backtrace pruning logic

It was discovered rust-lang#40264 that this backtrace pruning logic is a little too
aggressive, so while we figure how out to handle rust-lang#40264 this commit backs out
the changes to prune frames. Note that other cosmetic changes, such as better
path printing and such remain.
This was referenced Apr 18, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 18, 2017
…r=petrochenkov

std: Back out backtrace pruning logic

It was discovered rust-lang#40264 that this backtrace pruning logic is a little too
aggressive, so while we figure how out to handle rust-lang#40264 this commit backs out
the changes to prune frames. Note that other cosmetic changes, such as better
path printing and such remain.
bors added a commit that referenced this pull request Apr 18, 2017
Rollup of 6 pull requests

- Successful merges: #40290, #41353, #41356, #41360, #41361, #41364
- Failed merges:
@bors bors merged commit e46a8bd into rust-lang:master Apr 18, 2017
@alexcrichton alexcrichton deleted the less-backtrace-prune branch April 19, 2017 16:05
@CryZe
Copy link
Contributor

CryZe commented Apr 27, 2017

This might've unintentionally removed the message that shows that you can switch to a full backtrace with "RUST_BACKTRACE=full", because the logic for it checks whether frames got omitted:

if skipped_before + skipped_after > 0 {

So this message never shows up.

@alexcrichton
Copy link
Member Author

@CryZe that's somewhat intentional, the =full just adds in the addresses currently where the primary intention is to add in frames. No frames are ever omitted currently, so the utility of =full is somewhat reduced today.

@CryZe
Copy link
Contributor

CryZe commented Apr 27, 2017

Ah okay, thanks for clarifying :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants