Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Final backports to beta #41427

Merged
merged 5 commits into from
Apr 21, 2017
Merged

[beta] Final backports to beta #41427

merged 5 commits into from
Apr 21, 2017

Conversation

alexcrichton
Copy link
Member

eddyb and others added 4 commits April 20, 2017 13:17
@eddyb @alexcrichton
Avoid type-checking addition and indexing twice.
eec7897
@nagisa @alexcrichton
Properly adjust filenames when multiple emissions
1364ffc 
Fixes rust-lang#40993
@alexcrichton
Disable debuginfo when compiling tools
275549b 
Currently the Cargo binary has jumped from 14M to 34M on the beta channel, which
appears to be due to the fact that we're compiling tools with debug information
inside them. This additionally means that the `rls` binary is 62M right now!

This wasn't an intentional change, so be sure to disable debuginfo when
compiling tools as it's just intended for the standard library and compile for
now.
@eddyb @alexcrichton
rustc_trans: do not treat byval as using up registers.
7b44392
@rust-highfive
Copy link
Collaborator

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@alexcrichton
Copy link
Member Author

@bors: r+ p=5

(beta backports)

@bors
Copy link
Contributor

bors commented Apr 20, 2017

📌 Commit 7b44392 has been approved by alexcrichton

@alexcrichton alexcrichton mentioned this pull request Apr 20, 2017
Closed
@bors
Copy link
Contributor

bors commented Apr 20, 2017

⌛ Testing commit 7b44392 with merge 732672b...

@bors
Copy link
Contributor

bors commented Apr 20, 2017

💔 Test failed - status-travis

@arielb1
Copy link
Contributor

arielb1 commented Apr 20, 2017 

error[E0369]: binary operation `!=` cannot be applied to type `Mode`

   --> /checkout/src/bootstrap/lib.rs:477:12

    |

477 |         if mode != Mode::Tool {

    |            ^^^^

    |

@alexcrichton
Copy link
Member Author

@bors: r+

@bors
Copy link
Contributor

bors commented Apr 20, 2017

📌 Commit e7eda62 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Apr 20, 2017

⌛ Testing commit e7eda62 with merge fffafd3...

@bors
Copy link
Contributor

bors commented Apr 20, 2017

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member Author

@bors: retry

@bors
Copy link
Contributor

bors commented Apr 21, 2017

⌛ Testing commit e7eda62 with merge 3cc1e39...

bors added a commit that referenced this pull request Apr 21, 2017
@bors
Auto merge of #41427 - alexcrichton:beta-next, r=alexcrichton
3cc1e39 
[beta] Final backports to beta

Backport of:

* #40863
* #41085
* #41354
* #41378
@bors
Copy link
Contributor

bors commented Apr 21, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 3cc1e39 to beta...

@bors bors merged commit e7eda62 into rust-lang:beta Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@arielb1 arielb1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexcrichton @rust-highfive @bors @arielb1 @eddyb @nagisa