Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for issue 33884 #41435

Merged
merged 1 commit into from
Apr 22, 2017
Merged

Add test for issue 33884 #41435

merged 1 commit into from
Apr 22, 2017

Conversation

estebank
Copy link
Contributor

Fix #33884.

r=nikomatsakis

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@shepmaster
Copy link
Member

Thank you, @estebank! We'll check in every so often to make sure that @nikomatsakis or another reviewer gets back to you soon!

nikomatsakis
nikomatsakis approved these changes Apr 21, 2017
View reviewed changes
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Apr 21, 2017

📌 Commit 903bdfc has been approved by nikomatsakis

@shepmaster shepmaster added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 21, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 21, 2017
@frewsxcv
Rollup merge of rust-lang#41435 - estebank:issue-33884, r=nikomatsakis
674f728 
Add test for issue 33884

Fix rust-lang#33884.

r=nikomatsakis
@frewsxcv frewsxcv mentioned this pull request Apr 21, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 22, 2017
@frewsxcv
Rollup merge of rust-lang#41435 - estebank:issue-33884, r=nikomatsakis
38439cc 
Add test for issue 33884

Fix rust-lang#33884.

r=nikomatsakis
@frewsxcv frewsxcv mentioned this pull request Apr 22, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 22, 2017
@frewsxcv
Rollup merge of rust-lang#41435 - estebank:issue-33884, r=nikomatsakis
7ac821d 
Add test for issue 33884

Fix rust-lang#33884.

r=nikomatsakis
@frewsxcv frewsxcv mentioned this pull request Apr 22, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 22, 2017
@frewsxcv
Rollup merge of rust-lang#41435 - estebank:issue-33884, r=nikomatsakis
df72158 
Add test for issue 33884

Fix rust-lang#33884.

r=nikomatsakis
@frewsxcv frewsxcv mentioned this pull request Apr 22, 2017
Merged
bors added a commit that referenced this pull request Apr 22, 2017
@bors
Auto merge of #41459 - frewsxcv:rollup, r=frewsxcv
ff13b7c 
Rollup of 4 pull requests

- Successful merges: #37658, #41405, #41432, #41435
- Failed merges:
@bors bors merged commit 903bdfc into rust-lang:master Apr 22, 2017
@estebank estebank deleted the issue-33884 branch November 9, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@estebank @rust-highfive @shepmaster @nikomatsakis @bors