Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 4 pull requests #41445

Merged
merged 10 commits into from
Apr 21, 2017
Merged

Rollup of 4 pull requests #41445

merged 10 commits into from
Apr 21, 2017

Conversation

frewsxcv
Copy link
Member

nbigaouette and others added 10 commits April 18, 2017 14:00
@nbigaouette
Use an (over-writable) environment variable for the gdb command
82ed783 
Instead of hard-coding the command to run, using the environment
variable `GDB_CMD` (that defaults to `gdb`) allows using a different
debugger than the default `gdb` executable.

This gives the possibility to use `cgdb` as the debugger, which provides
a nicer user interface. Note that one has to use `GDB_CMD="cgdb --"` to
use cgdb (note the trailing `--`) to let cgdb pass the proper arguments
to `gdb`.
@nbigaouette
Rename environment variable GDB_CMD to RUST_GDB to prevent ambiguity
61b7ebe
@malbarbo
Update libc to include x86_64-linux-android support
416d6b7
@mbrubeck
Expanded docs and examples for PathBuf::file_name and friends
3b4d34d
@malbarbo
Add x86_64-linux-android target
51cc0e3
Bump the rls submodule revision
865f5d0
@frewsxcv
Rollup merge of rust-lang#41372 - nbigaouette:master, r=alexcrichton
cf11d3c 
Use an (over-writable) environment variable for the `gdb` command

Instead of hard-coding the command to run, using the environment
variable `GDB_CMD` (that defaults to `gdb`) allows using a different
debugger than the default `gdb` executable.

This gives the possibility to use `cgdb` as the debugger, which provides
a nicer user interface. Note that one has to use `GDB_CMD="cgdb --"` to
use cgdb (note the trailing `--`) to let cgdb pass the proper arguments
to `gdb`.
@frewsxcv
Rollup merge of rust-lang#41376 - mbrubeck:docs, r=frewsxcv
d983256 
Expanded docs and examples for PathBuf::file_name and friends

This addresses some common surprises when `PathBuf::set_file_name` is called on the path of a directory rather than a file.

r? @steveklabnik
@frewsxcv
Rollup merge of rust-lang#41426 - malbarbo:android-x86_64, r=alexcric…
d5bbeb1 
…hton

Add x86_64-linux-android target
@frewsxcv
Rollup merge of rust-lang#41429 - jonathandturner:update_rls_submod, …
35dd55d 
…r=alexcrichton

Bump the rls submodule revision

Bump the RLS version to include a few recent fixes.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv
Copy link
Member Author

@bors r+ p=10

@bors
Copy link
Contributor

bors commented Apr 21, 2017

📌 Commit 35dd55d has been approved by frewsxcv

@bors
Copy link
Contributor

bors commented Apr 21, 2017

⌛ Testing commit 35dd55d with merge 445f4fe...

@bors
Copy link
Contributor

bors commented Apr 21, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

@bors: retry

@shepmaster shepmaster added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 21, 2017
@bors
Copy link
Contributor

bors commented Apr 21, 2017

⌛ Testing commit 35dd55d with merge 1785bca...

bors added a commit that referenced this pull request Apr 21, 2017
@bors
Auto merge of #41445 - frewsxcv:rollup, r=frewsxcv
1785bca 
Rollup of 4 pull requests

- Successful merges: #41372, #41376, #41426, #41429
- Failed merges:
@bors
Copy link
Contributor

bors commented Apr 21, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: frewsxcv
Pushing 1785bca to master...

@bors bors merged commit 35dd55d into rust-lang:master Apr 21, 2017
@bors bors mentioned this pull request Apr 21, 2017
Closed
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@frewsxcv @rust-highfive @bors @alexcrichton @brson @shepmaster @Centril @nbigaouette @malbarbo @mbrubeck