appveyor: Use Ninja/sccache on MSVC #41447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
Note that after this we'll finally be using sccache on 100% of our platforms, yay for consistent caching solutions! |
Mark-Simulacrum
added
the
S-waiting-on-review
nagisa
reviewed
Apr 24, 2017
src/bootstrap/native.rs
Outdated
| build.config.ccache.is_some() { | ||
| let mut cc = env::current_exe().unwrap(); | ||
| cc.pop(); | ||
| cc.push("sccache-plus-cl.exe"); |
There was a problem hiding this comment.
Use PathBuf::set_file_name instead.
nagisa
reviewed
Apr 24, 2017
src/bootstrap/native.rs
Outdated
| if target.contains("msvc") && | ||
| build.config.ninja && | ||
| build.config.ccache.is_some() { | ||
| let mut cc = env::current_exe().unwrap(); |
There was a problem hiding this comment.
Use expect with at least somewhat greppable string.
nagisa
reviewed
Apr 24, 2017
src/bootstrap/bin/sccache-plus-cl.rs
Outdated
| let compiler = cfg.get_compiler(); | ||
|
|
||
| // Invoke sccache with said compiler | ||
| let mut cmd = Command::new("sccache"); |
There was a problem hiding this comment.
Doesn’t this ignore the path to sccache that can be specified in the config.toml?
|
Didn’t look at changes to yaml/Dockerfiles. Commented for the rest. |
alexcrichton
force-pushed
the
sccache-everywhere
branch
from
c797287
to
d75528e
Compare
|
@bors r+ |
|
📌 Commit d75528e has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 26, 2017
…brson appveyor: Use Ninja/sccache on MSVC Now that the final bug fixes have been merged into sccache we can start leveraging sccache on the MSVC builders on AppVeyor instead of relying on the ad-hoc caching strategy of trigger files and whatnot.
alexcrichton
added
S-waiting-on-bors
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 26, 2017
…brson appveyor: Use Ninja/sccache on MSVC Now that the final bug fixes have been merged into sccache we can start leveraging sccache on the MSVC builders on AppVeyor instead of relying on the ad-hoc caching strategy of trigger files and whatnot.
bors
added a commit
that referenced
this pull request
Apr 26, 2017
alexcrichton
force-pushed
the
sccache-everywhere
branch
from
d75528e
to
970e2a9
Compare
|
@bors: r=brson |
|
📌 Commit 970e2a9 has been approved by |
|
⌛ Testing commit 970e2a9 with merge 3fa950c... |
|
💔 Test failed - status-appveyor |
|
@bors retry Appveyor network issues https://appveyor.statuspage.io/incidents/06gzq846jl9x |
|
⌛ Testing commit 970e2a9 with merge 0f9d66f... |
|
💔 Test failed - status-appveyor |
|
Legitimate failure, I think: |
This build is no longer a forked version with temporary bugfixes, everything should be upstreamed!
Now that the final bug fixes have been merged into sccache we can start leveraging sccache on the MSVC builders on AppVeyor instead of relying on the ad-hoc caching strategy of trigger files and whatnot.
alexcrichton
force-pushed
the
sccache-everywhere
branch
from
970e2a9
to
2e72bcb
Compare
|
@bors: r=brson |
|
📌 Commit 2e72bcb has been approved by |
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Apr 27, 2017
…brson appveyor: Use Ninja/sccache on MSVC Now that the final bug fixes have been merged into sccache we can start leveraging sccache on the MSVC builders on AppVeyor instead of relying on the ad-hoc caching strategy of trigger files and whatnot.
bors
added a commit
that referenced
this pull request
Apr 27, 2017
appveyor: Use Ninja/sccache on MSVC Now that the final bug fixes have been merged into sccache we can start leveraging sccache on the MSVC builders on AppVeyor instead of relying on the ad-hoc caching strategy of trigger files and whatnot.
|
☀️ Test successful - status-appveyor, status-travis |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Apr 29, 2017
Pulls in mozilla/sccache@ef0d77543 to fix rust-lang#40240 again after the builds included in rust-lang#41447 forgot to include the mio fixed included in rust-lang#41076. Closes rust-lang#40240
bors
added a commit
that referenced
this pull request
Apr 29, 2017
ci: Update sccache build Pulls in mozilla/sccache@ef0d77543 to fix #40240 again after the builds included in #41447 forgot to include the mio fixed included in #41076. Closes #40240
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the final bug fixes have been merged into sccache we can start
leveraging sccache on the MSVC builders on AppVeyor instead of relying on the
ad-hoc caching strategy of trigger files and whatnot.