[beta] Prepare the 1.18.0 beta release #41525
Conversation
* Update the cargo submodule * Update the stage0 bootstrap compiler, temporarily downloading it from dev-static.rust-lang.org until it's released this Thursday. * Update release channel being compiled to beta * Disable the RLS release (will only happen on this one beta release)
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -201,8 +201,8 @@ def download_stage0(self): | |||
| if self.cargo().startswith(self.bin_root()) and \ | |||
| (not os.path.exists(self.cargo()) or self.cargo_out_of_date()): | |||
| self.print_what_it_means_to_bootstrap() | |||
| filename = "cargo-{}-{}.tar.gz".format(channel, self.build) | |||
| url = "https://static.rust-lang.org/dist/" + self.stage0_rustc_date() | |||
| filename = "cargo-{}-{}.tar.gz".format('0.18.0', self.build) | |||
There was a problem hiding this comment.
Note that this is a bit of an unfortunate hack, I'll try to clean it up on the master branch so we don't have to do this again. This version number should be configured in src/stage0.txt
| @@ -171,7 +171,7 @@ def download_stage0(self): | |||
| if os.path.exists(self.bin_root()): | |||
| shutil.rmtree(self.bin_root()) | |||
| filename = "rust-std-{}-{}.tar.gz".format(channel, self.build) | |||
| url = "https://static.rust-lang.org/dist/" + self.stage0_rustc_date() | |||
| url = "https://dev-static.rust-lang.org/dist/" + self.stage0_rustc_date() | |||
There was a problem hiding this comment.
This is sort of up in the air as a convention. The old buildbot code would deploy to the archives and then we'd manually do the full release (change the manifests and put artifacts at dist/*.tar.gz. Now with rust-central-station nothing goes to prod on stable until we run the command manually. That means that until we actually do the release we wouldn't be able to create a new beta and/or nightly.
I'm personally thinking:
- We create a new stable build
- Stable uploads to dev
- Create a new beta bootstrapping from dev
- Beta is uploaded to prod
- Create a new nightly bootstrapping from beta (on prod)
- Do a release
- Send a PR to beta to bootstrap from prod
One extra PR but allows us to get beta/nightlies sooner, which I sorta like. Thoughts @brson?
There was a problem hiding this comment.
It's unfortunate to make dev-static part of the public history, but for now fine, and I don't want to care too much.
|
@bors r+ This is a lot of churn for a mechanical bump. Needs some streamlining. Just the URLs I guess. |
|
📌 Commit c430eff has been approved by |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit c430eff has been approved by |
|
@bors: p=100 |
|
⌛ Testing commit c430eff with merge 4dce672... |
[beta] Prepare the 1.18.0 beta release * Update the cargo submodule * Update the stage0 bootstrap compiler, temporarily downloading it from dev-static.rust-lang.org until it's released this Thursday. * Update release channel being compiled to beta * Disable the RLS release (will only happen on this one beta release)
|
☀️ Test successful - status-appveyor, status-travis |
dev-static.rust-lang.org until it's released this Thursday.