Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librustc: Fix explicit self for objects in more cases #4155

Closed
wants to merge 1 commit into from
Closed

librustc: Fix explicit self for objects in more cases #4155

wants to merge 1 commit into from

Conversation

pcwalton
Copy link
Contributor

@nikomatsakis
Copy link
Contributor

I don't fully see why we need to do things so differently for objects. I feel like the vtables should contains functions that perform whatever adaptation is needed. That said, r+ to this patch, which seems like an improvement on the current state.

@pcwalton pcwalton closed this Dec 13, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcwalton @nikomatsakis