-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 4 pull requests #41573
Rollup of 4 pull requests #41573
Conversation
frewsxcv
commented
Apr 27, 2017
- Successful merges: make *most* maps private #41368, Implement a file-path remapping feature in support of debuginfo and reproducible builds #41508, Add missing OperandPair struct field index adjustments. Fixes #41479. #41529, Shrink the rust-src component #41546
- Failed merges: cache symbol names in ty::maps #41507, query for describe_def #41534
Some accesses in OperandPairs were missing. Fixes rust-lang#41479.
…eproducible builds.
Didn't get around to removing all public access.
This requires copying out the cycle error to avoid a cyclic borrow. Is this a problem? Are there paths where we expect cycles to arise and not result in errors? (In such cases, we could add a faster way to test for cycle.)
…-map, r=eddyb make *most* maps private Currently we access the `DepTrackingMap` fields directly rather than using the query accessors. This seems bad. This branch removes several such uses, but not all, and extends the macro so that queries can hide their maps (so we can prevent regressions). The extension to the macro is kind of ugly :/ but couldn't find a simple way to do it otherwise (I guess I could use a nested macro...). Anyway I figure it's only temporary. r? @eddyb
…ping, r=alexcrichton Implement a file-path remapping feature in support of debuginfo and reproducible builds This PR adds the `-Zremap-path-prefix-from`/`-Zremap-path-prefix-to` commandline option pair and is a more general implementation of rust-lang#41419. As opposed to the previous attempt, this implementation should enable reproducible builds regardless of the working directory of the compiler. This implementation of the feature is more general in the sense that the re-mapping will affect *all* paths the compiler emits, including the ones in error messages. r? @alexcrichton
Add missing OperandPair struct field index adjustments. Fixes rust-lang#41479. This is a bug fix for a regression in rust-lang@6d841da.
@bors r+ p=10 |
📌 Commit 4c725d2 has been approved by |
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
⌛ Testing commit 4c725d2 with merge 097d9bc... |
💔 Test failed - status-travis |
Seems legit |
Unsure which PR that was from after a quick look (even if I was I don't know how to create a rollup), so all of the individual PRs are still queued (retried after appveyor network failures). (particularly odd is that each of the PRs passed the travis PR check) |