Implement read_managed_str for the JSON deserialiser. #4159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FIXME is an underlying issue (a core::at_str library) that this doesn't address.
|
Nice catch, thanks! |
|
landed in 76dc781 |
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Feb 2, 2025
…-solaris Set st_fstype of stat on Solaris and Illumos OSes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there is now a
.to_managedmethod to convert a~strto a@str, so use this to implement the last method of the JSON deserialiser.It mentions #3604, but this doesn't fix that issue.
(PS. I'm new here; I've read the notes for developers on the wiki, but it's entirely feasible that I'm making mistakes anyway. Sorry!)