Rollup of 5 pull requests #41634
Closed
Rollup of 5 pull requests #41634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
frewsxcv
commented
Apr 29, 2017
frewsxcv
commented
- Successful merges: FromIterator and Extend Cow for String #41449, reduce stack requirements for floating-point formatting #41509, Add a distcheck for rust-src completeness #41608, Fix links in RELEASES.md for 1.10.0 through 1.12.0 #41613, Unignore android for previously spuriously failing test. #41618
- Failed merges:
Many links in this series have the `[link text]` and `(url)` on separate lines, which doesn't get correctly interpreted in markdown. Or maybe it once did, but it doesn't now. This patch joins the lines together.
We have benchmarks for the floating-point formatting algorithms themselves, but not for the surrounding machinery like Formatter and translating to the flt2dec::Part slices.
For the two major entry points for float formatting, we split the exact case and the shortest cases into separate functions. We mark the separate functions as #[inline(never) so the exact cases won't bloat stack space in their callers unnecessarily. The shortest cases are marked so for similar reasons. Fixes rust-lang#41234.
The comments for flt2dec::to_shortest_str says that we only need a slice of length 5 for the parts array. Initializing a 16-part array is just wasted effort and wasted stack space. Other functions in the flt2dec module have similar comments, so we adjust the parts arrays passed to those functions accordingly.
Spending time to initialize these is just wasted work, as we'll overwrite them soon anyway. Fixes rust-lang#41259.
Will see if this start failing again, in which case we'll re-ignore the test.
FromIterator and Extend Cow for String This is a quick draft to start working on [rust-lang#41351](rust-lang#41351). I don't think I got the stable attributes correct, but it is good enuf to start a conversation.
…gisa reduce stack requirements for floating-point formatting Doing this speeds up float formatting by ~10% or so, and also makes the formatting code more suitable for embedded environments where stack space is at a premium.
…richton Add a distcheck for rust-src completeness This is for the last commit of rust-lang#41546. For some reason, @bors only saw the first two commits, and wouldn't approve the last even when explicitly directed so. r? @alexcrichton
Fix links in RELEASES.md for 1.10.0 through 1.12.0 Many links in this series have the `[link text]` and `(url)` on separate lines, which doesn't get correctly interpreted in markdown. Or maybe it once did, but it doesn't now. This patch joins the lines together. Here is the content rendered [before](https://github.com/rust-lang/rust/blob/2971d491b955fd8bb504c8ca675b8116b8b1550e/RELEASES.md#version-1120-2016-09-29) and [after](https://github.com/cuviper/rust/blob/e8c4b7af216c9e035b40f78cbd77a35614fdc240/RELEASES.md#version-1120-2016-09-29).
…turon Unignore android for previously spuriously failing test. Will see if this start failing again, in which case we'll re-ignore the test. In theory, rust-lang#20004 could be fixed by this. I've left that open because it's possible that this will resume the previous spurious failures, and marked it as A-spurious so people doing PR triage catch that. I will leave a comment there saying that if we see failures from this test on android, we should re-ignore it.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors r+ p=10 |
|
📌 Commit f99a1d5 has been approved by |
|
⌛ Testing commit f99a1d5 with merge 0fa8165... |
|
💔 Test failed - status-travis |
|
legit fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.