Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings when rustdoc html rendering differs #41991

Merged
merged 8 commits into from
Aug 31, 2017

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented May 14, 2017

No description provided.

@rust-highfive
Copy link
Collaborator

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

@Mark-Simulacrum Mark-Simulacrum added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 14, 2017
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented May 15, 2017

The error (you can see it on travis as well):

./x.py test src/test/rustdoc/ --stage 1
    Finished dev [unoptimized] target(s) in 0.0 secs
Synchronizing submodule url for 'src/compiler-rt'
Synchronizing submodule url for 'src/doc/book'
Synchronizing submodule url for 'src/doc/nomicon'
Synchronizing submodule url for 'src/doc/reference'
Synchronizing submodule url for 'src/jemalloc'
Synchronizing submodule url for 'src/liblibc'
Synchronizing submodule url for 'src/llvm'
Synchronizing submodule url for 'src/rt/hoedown'
Synchronizing submodule url for 'src/rust-installer'
Synchronizing submodule url for 'src/tools/cargo'
Synchronizing submodule url for 'src/tools/rls'
HEAD is now at c8a8767 Merge pull request #26 from TimNN/arm-cc
HEAD is now at ad7de19 Merge pull request #631 from frewsxcv/new-unstable-book-links
HEAD is now at 6fa139b Merge pull request #18 from Gankro/master
HEAD is now at 6b0de90 Merge pull request #43 from frewsxcv/fix-link
HEAD is now at 3288e06 Merge pull request #18 from arthurprs/update-to-4.5.0
HEAD is now at 03562b0 Auto merge of #585 - jonhoo:res_init, r=alexcrichton
HEAD is now at 1ef3b91 Merge pull request #78 from pftbest/msp430_libcalls
Removing utils/llvm-build/llvmbuild/__init__.pyc
Removing utils/llvm-build/llvmbuild/componentinfo.pyc
Removing utils/llvm-build/llvmbuild/configutil.pyc
Removing utils/llvm-build/llvmbuild/main.pyc
Removing utils/llvm-build/llvmbuild/util.pyc
HEAD is now at da282f1 Merge pull request #8 from GuillaumeGomez/line_information
HEAD is now at 2e6417f Merge pull request #61 from TimNN/tar-sort-default
HEAD is now at cf17c9f Auto merge of #4010 - jonhoo:better-incremental-nightly-test, r=alexcrichton
HEAD is now at 38ca9b7 Merge pull request #314 from martinschleiss/master
Building stage0 std artifacts (x86_64-apple-darwin -> x86_64-apple-darwin)
    Finished release [optimized] target(s) in 0.0 secs
Copying stage0 std from stage0 (x86_64-apple-darwin -> x86_64-apple-darwin / x86_64-apple-darwin)
Building stage0 test artifacts (x86_64-apple-darwin -> x86_64-apple-darwin)
    Finished release [optimized] target(s) in 0.0 secs
Copying stage0 test from stage0 (x86_64-apple-darwin -> x86_64-apple-darwin / x86_64-apple-darwin)
Building stage0 compiler artifacts (x86_64-apple-darwin -> x86_64-apple-darwin)
warning: ../rustllvm/PassWrapper.cpp:285:3: warning: default label in switch which covers all enumeration values [-Wcovered-switch-default]
warning:   default:
warning:   ^
warning: 1 warning generated.
   Compiling html5ever v0.13.1
   Compiling rustc_back v0.0.0 (file:///Users/imperio/rust/rust/src/librustc_back)
   Compiling rustc_const_math v0.0.0 (file:///Users/imperio/rust/rust/src/librustc_const_math)
   Compiling proc_macro v0.0.0 (file:///Users/imperio/rust/rust/src/libproc_macro)
error: use of unstable library feature 'rustc_private' (see issue #27812)
  --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/lib.rs:21:1
   |
21 | extern crate log;
   | ^^^^^^^^^^^^^^^^^
   |
   = help: add #![feature(rustc_private)] to the crate attributes to enable

error: use of unstable library feature 'rustc_private' (see issue #27812)
  --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/serialize/mod.rs:71:13
   |
71 |             warn!("node with weird namespace {:?}", ns);
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: add #![feature(rustc_private)] to the crate attributes to enable
   = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
  --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/serialize/mod.rs:71:13
   |
71 |             warn!("node with weird namespace {:?}", ns);
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: add #![feature(rustc_private)] to the crate attributes to enable
   = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
  --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/serialize/mod.rs:71:13
   |
71 |             warn!("node with weird namespace {:?}", ns);
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: add #![feature(rustc_private)] to the crate attributes to enable
   = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
  --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/serialize/mod.rs:71:13
   |
71 |             warn!("node with weird namespace {:?}", ns);
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: add #![feature(rustc_private)] to the crate attributes to enable
   = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
  --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/serialize/mod.rs:71:13
   |
71 |             warn!("node with weird namespace {:?}", ns);
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: add #![feature(rustc_private)] to the crate attributes to enable
   = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
  --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/serialize/mod.rs:71:13
   |
71 |             warn!("node with weird namespace {:?}", ns);
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: add #![feature(rustc_private)] to the crate attributes to enable
   = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/serialize/mod.rs:144:21
    |
144 |                     warn!("attr with weird namespace {:?}", ns);
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/serialize/mod.rs:144:21
    |
144 |                     warn!("attr with weird namespace {:?}", ns);
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/char_ref/mod.rs:126:9
    |
126 |         debug!("char ref tokenizer stepping in state {:?}", self.state);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/char_ref/mod.rs:126:9
    |
126 |         debug!("char ref tokenizer stepping in state {:?}", self.state);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:289:9
    |
289 |         debug!("got character {}", c);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:289:9
    |
289 |         debug!("got character {}", c);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:315:9
    |
315 |         debug!("got characters {:?}", d);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:315:9
    |
315 |         debug!("got characters {:?}", d);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:694:9
    |
694 |         debug!("processing in state {:?}", self.state);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:694:9
    |
694 |         debug!("processing in state {:?}", self.state);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
    --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:1331:9
     |
1331 |         debug!("processing EOF in state {:?}", self.state);
     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: add #![feature(rustc_private)] to the crate attributes to enable
     = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
    --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:1331:9
     |
1331 |         debug!("processing EOF in state {:?}", self.state);
     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: add #![feature(rustc_private)] to the crate attributes to enable
     = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tree_builder/actions.rs:170:9
    |
170 |         warn!("stop_parsing not implemented, full speed ahead!");
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tree_builder/actions.rs:170:9
    |
170 |         warn!("stop_parsing not implemented, full speed ahead!");
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tree_builder/actions.rs:672:9
    |
672 |         warn!("foster parenting not implemented");
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tree_builder/actions.rs:672:9
    |
672 |         warn!("foster parenting not implemented");
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tree_builder/mod.rs:308:9
    |
308 |         debug!("processing {} in insertion mode {:?}", to_escaped_string(token), mode);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tree_builder/mod.rs:308:9
    |
308 |         debug!("processing {} in insertion mode {:?}", to_escaped_string(token), mode);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/serialize/mod.rs:144:21
    |
144 |                     warn!("attr with weird namespace {:?}", ns);
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/serialize/mod.rs:144:21
    |
144 |                     warn!("attr with weird namespace {:?}", ns);
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/serialize/mod.rs:144:21
    |
144 |                     warn!("attr with weird namespace {:?}", ns);
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/serialize/mod.rs:144:21
    |
144 |                     warn!("attr with weird namespace {:?}", ns);
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/char_ref/mod.rs:126:9
    |
126 |         debug!("char ref tokenizer stepping in state {:?}", self.state);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/char_ref/mod.rs:126:9
    |
126 |         debug!("char ref tokenizer stepping in state {:?}", self.state);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/char_ref/mod.rs:126:9
    |
126 |         debug!("char ref tokenizer stepping in state {:?}", self.state);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/char_ref/mod.rs:126:9
    |
126 |         debug!("char ref tokenizer stepping in state {:?}", self.state);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:289:9
    |
289 |         debug!("got character {}", c);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:289:9
    |
289 |         debug!("got character {}", c);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:289:9
    |
289 |         debug!("got character {}", c);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:289:9
    |
289 |         debug!("got character {}", c);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:315:9
    |
315 |         debug!("got characters {:?}", d);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:315:9
    |
315 |         debug!("got characters {:?}", d);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:315:9
    |
315 |         debug!("got characters {:?}", d);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:315:9
    |
315 |         debug!("got characters {:?}", d);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:694:9
    |
694 |         debug!("processing in state {:?}", self.state);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:694:9
    |
694 |         debug!("processing in state {:?}", self.state);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:694:9
    |
694 |         debug!("processing in state {:?}", self.state);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:694:9
    |
694 |         debug!("processing in state {:?}", self.state);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
    --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:1331:9
     |
1331 |         debug!("processing EOF in state {:?}", self.state);
     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: add #![feature(rustc_private)] to the crate attributes to enable
     = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
    --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:1331:9
     |
1331 |         debug!("processing EOF in state {:?}", self.state);
     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: add #![feature(rustc_private)] to the crate attributes to enable
     = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
    --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:1331:9
     |
1331 |         debug!("processing EOF in state {:?}", self.state);
     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: add #![feature(rustc_private)] to the crate attributes to enable
     = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
    --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:1331:9
     |
1331 |         debug!("processing EOF in state {:?}", self.state);
     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: add #![feature(rustc_private)] to the crate attributes to enable
     = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tree_builder/actions.rs:170:9
    |
170 |         warn!("stop_parsing not implemented, full speed ahead!");
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tree_builder/actions.rs:170:9
    |
170 |         warn!("stop_parsing not implemented, full speed ahead!");
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tree_builder/actions.rs:170:9
    |
170 |         warn!("stop_parsing not implemented, full speed ahead!");
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tree_builder/actions.rs:170:9
    |
170 |         warn!("stop_parsing not implemented, full speed ahead!");
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tree_builder/actions.rs:672:9
    |
672 |         warn!("foster parenting not implemented");
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tree_builder/actions.rs:672:9
    |
672 |         warn!("foster parenting not implemented");
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tree_builder/actions.rs:672:9
    |
672 |         warn!("foster parenting not implemented");
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tree_builder/actions.rs:672:9
    |
672 |         warn!("foster parenting not implemented");
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tree_builder/mod.rs:308:9
    |
308 |         debug!("processing {} in insertion mode {:?}", to_escaped_string(token), mode);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tree_builder/mod.rs:308:9
    |
308 |         debug!("processing {} in insertion mode {:?}", to_escaped_string(token), mode);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tree_builder/mod.rs:308:9
    |
308 |         debug!("processing {} in insertion mode {:?}", to_escaped_string(token), mode);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tree_builder/mod.rs:308:9
    |
308 |         debug!("processing {} in insertion mode {:?}", to_escaped_string(token), mode);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
  --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/serialize/mod.rs:71:13
   |
71 |             warn!("node with weird namespace {:?}", ns);
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: add #![feature(rustc_private)] to the crate attributes to enable
   = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
  --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/serialize/mod.rs:71:13
   |
71 |             warn!("node with weird namespace {:?}", ns);
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: add #![feature(rustc_private)] to the crate attributes to enable
   = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
  --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/serialize/mod.rs:71:13
   |
71 |             warn!("node with weird namespace {:?}", ns);
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: add #![feature(rustc_private)] to the crate attributes to enable
   = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/serialize/mod.rs:144:21
    |
144 |                     warn!("attr with weird namespace {:?}", ns);
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/serialize/mod.rs:144:21
    |
144 |                     warn!("attr with weird namespace {:?}", ns);
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/serialize/mod.rs:144:21
    |
144 |                     warn!("attr with weird namespace {:?}", ns);
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/char_ref/mod.rs:126:9
    |
126 |         debug!("char ref tokenizer stepping in state {:?}", self.state);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/char_ref/mod.rs:126:9
    |
126 |         debug!("char ref tokenizer stepping in state {:?}", self.state);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/char_ref/mod.rs:126:9
    |
126 |         debug!("char ref tokenizer stepping in state {:?}", self.state);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:289:9
    |
289 |         debug!("got character {}", c);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:289:9
    |
289 |         debug!("got character {}", c);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:289:9
    |
289 |         debug!("got character {}", c);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:315:9
    |
315 |         debug!("got characters {:?}", d);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:315:9
    |
315 |         debug!("got characters {:?}", d);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:315:9
    |
315 |         debug!("got characters {:?}", d);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:694:9
    |
694 |         debug!("processing in state {:?}", self.state);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:694:9
    |
694 |         debug!("processing in state {:?}", self.state);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:694:9
    |
694 |         debug!("processing in state {:?}", self.state);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
    --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:1331:9
     |
1331 |         debug!("processing EOF in state {:?}", self.state);
     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: add #![feature(rustc_private)] to the crate attributes to enable
     = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
    --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:1331:9
     |
1331 |         debug!("processing EOF in state {:?}", self.state);
     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: add #![feature(rustc_private)] to the crate attributes to enable
     = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
    --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tokenizer/mod.rs:1331:9
     |
1331 |         debug!("processing EOF in state {:?}", self.state);
     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: add #![feature(rustc_private)] to the crate attributes to enable
     = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tree_builder/actions.rs:170:9
    |
170 |         warn!("stop_parsing not implemented, full speed ahead!");
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tree_builder/actions.rs:170:9
    |
170 |         warn!("stop_parsing not implemented, full speed ahead!");
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tree_builder/actions.rs:170:9
    |
170 |         warn!("stop_parsing not implemented, full speed ahead!");
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tree_builder/actions.rs:672:9
    |
672 |         warn!("foster parenting not implemented");
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tree_builder/actions.rs:672:9
    |
672 |         warn!("foster parenting not implemented");
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tree_builder/actions.rs:672:9
    |
672 |         warn!("foster parenting not implemented");
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tree_builder/mod.rs:308:9
    |
308 |         debug!("processing {} in insertion mode {:?}", to_escaped_string(token), mode);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tree_builder/mod.rs:308:9
    |
308 |         debug!("processing {} in insertion mode {:?}", to_escaped_string(token), mode);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: use of unstable library feature 'rustc_private' (see issue #27812)
   --> /Users/imperio/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/html5ever-0.13.1/src/tree_builder/mod.rs:308:9
    |
308 |         debug!("processing {} in insertion mode {:?}", to_escaped_string(token), mode);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
    = note: this error originates in a macro outside of the current crate

error: aborting due to 30 previous errors

error: Could not compile `html5ever`.
Build failed, waiting for other jobs to finish...
error: build failed


command did not execute successfully: "/Users/imperio/rust/rust/build/x86_64-apple-darwin/stage0/bin/cargo" "build" "-j" "8" "--target" "x86_64-apple-darwin" "--release" "--features" " jemalloc" "--manifest-path" "/Users/imperio/rust/rust/src/rustc/Cargo.toml"
expected success, got: exit code: 101


Build completed unsuccessfully in 0:00:17

@nrc
Copy link
Member

nrc commented May 16, 2017

I think you need to add the following lines to html5ever and html-diff:

#![cfg_attr(rustbuild, feature(staged_api, rustc_private))]
#![cfg_attr(rustbuild, unstable(feature = "rustc_private", issue = "27812"))]

These are in log, which means that when building using Rustbuild, log is rustc_private. I think that therefore anything that has log as a dep (direct or transitive) must also have these lines. Note also that if you don't have these lines in html-diff, then you'll get a test error because the CI checks that every dependent crate has such lines. The motivation behind all this is that we don't want to put any stable (non-rustc_private) crates in the Rust sys_root.

@Mark-Simulacrum
Copy link
Member

I don't think that should be necessary with #41847... that should've made these flags completely unnecessary. Perhaps it wasn't successful, though.

@alexcrichton
Copy link
Member

@Mark-Simulacrum looks like this tool is compiled in stage0, which doesn't have those changes. @nrc yes for now that's what needs to be added, although those lines will no longer be necessary once the next stage0 passes due to the PR @Mark-Simulacrum mentioned.

@nrc
Copy link
Member

nrc commented May 16, 2017

@GuillaumeGomez could we skip running these tests (and thus building with html-diff) in stage0? (I'm not sure if that makes sense)

@bors
Copy link
Contributor

bors commented May 16, 2017

☔ The latest upstream changes (presumably #41843) made this pull request unmergeable. Please resolve the merge conflicts.

@GuillaumeGomez
Copy link
Member Author

I'll try then. Thanks!

@alexcrichton alexcrichton added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2017
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented May 19, 2017

Ok, now new issue:

error: cannot satisfy dependencies so `log` only shows up once
  |
  = help: having upstream crates all available in one format will likely make this go away

error: aborting due to previous error

error: Could not compile `rustdoc`.

Anyone has an idea please? :)

@nrc
Copy link
Member

nrc commented May 24, 2017

Looks like the problem is still there after a rebase. I tried reproducing locally, but my build got hit with a different error, which I think is just bad local state. Will try again to investigate tomorrow.

@nrc
Copy link
Member

nrc commented May 24, 2017

cc @alexcrichton in case this is a Rustbuild bug

@bors
Copy link
Contributor

bors commented May 25, 2017

☔ The latest upstream changes (presumably #42212) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton
Copy link
Member

Delete these lines and you're good to go.

@GuillaumeGomez GuillaumeGomez force-pushed the rustdoc-html-diff branch 2 times, most recently from 2966be2 to 78eee68 Compare May 25, 2017 21:09
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented May 25, 2017

Funny/interesting bug this time (we're getting close!). When I compile the stage1 version of rustdoc, the non-stage0 get_html_diff function isn't called (take a look at the last commit to see what I'm talking about). Anyone has an idea why? In other parts of the compiler, #[cfg(not(stage0)] seems to work, so why not in here?

@alexcrichton: I confirm it works, thanks a lot! However why the removal of these lines fixed it?

@GuillaumeGomez
Copy link
Member Author

@nrc (maybe @alexcrichton too?): We have an issue with a duplicate I think:

found possibly newer version of crate `bitflags` which `proc_macro` depends on

@nrc
Copy link
Member

nrc commented May 27, 2017

There are two versions of bitflags - the one pulled in from crates.io, and the one in-tree (rustc_bitflags). There are three different version of the crates.io bitflags crate, but this PR does not add any more.

@alexcrichton
Copy link
Member

This is a bug in rustbuild. The compiler already depends on bitflags v0.8.2, but this PR introduces an additional dependency on bitflags v0.7.0 through the kuchiki -> selectors -> bitflags dependency tree. You can work around this locally by updating all dependencies, or you can wait for the rustbuild bug to get fixed.

@GuillaumeGomez
Copy link
Member Author

Let's wait then. Remains now the problem with #[cfg(stage0)].

@bors
Copy link
Contributor

bors commented May 29, 2017

☔ The latest upstream changes (presumably #42246) made this pull request unmergeable. Please resolve the merge conflicts.

@Mark-Simulacrum
Copy link
Member

@GuillaumeGomez The relevant bug in rustbuild has been fixed, so I think we should be able to land this now. Otherwise, you can wait for a week and we can avoid the stage0 mess I think once beta is branched and released.

@GuillaumeGomez
Copy link
Member Author

I still have the other bug anyway. Putting it again if someone has an explanation:

Funny/interesting bug this time (we're getting close!). When I compile the stage1 version of rustdoc, the non-stage0 get_html_diff function isn't called (take a look at the last commit to see what I'm talking about). Anyone has an idea why? In other parts of the compiler, #[cfg(not(stage0)] seems to work, so why not in here?

@GuillaumeGomez
Copy link
Member Author

@kennytm: Thanks!

@bors: r=nrc

@bors
Copy link
Contributor

bors commented Aug 30, 2017

📌 Commit 76e3221 has been approved by nrc

@bors
Copy link
Contributor

bors commented Aug 30, 2017

⌛ Testing commit 76e3221 with merge 1c3f0f443c0721ebf124f01f58f9760dc0fd186b...

@bors
Copy link
Contributor

bors commented Aug 30, 2017

💔 Test failed - status-appveyor

@GuillaumeGomez
Copy link
Member Author

AWS error? I guess we can retry?

@bors: retry

@bors
Copy link
Contributor

bors commented Aug 30, 2017

⌛ Testing commit 76e3221 with merge 7c078ac4504668573917c1064f37c84686280e6d...

@bors
Copy link
Contributor

bors commented Aug 31, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Aug 31, 2017

x86_64-gnu-aux failed, same issue as #44028 (comment) (libgit2 version mismatch).

[01:16:33] thread '<unnamed>' panicked at 'assertion failed: `(left == right)`
[01:16:33]   left: `{"User-Agent: git/2.0 (libgit2 0.26.0)", "Accept: */*", "GET /foo/bar/info/refs?service=git-upload-pack HTTP/1.1"}`,
[01:16:33]  right: `{"Accept: */*", "GET /foo/bar/info/refs?service=git-upload-pack HTTP/1.1", "User-Agent: git/2.0 (libgit2 0.25.0)"}`', /checkout/src/tools/cargo/tests/build-auth.rs:46:8
[01:16:33] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:16:33] test http_auth_offered ... FAILED
[01:16:33] 
[01:16:33] failures:
[01:16:33] 
[01:16:33] ---- http_auth_offered stdout ----
[01:16:33] 	running `/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/cargo build -v`
[01:16:33] running `/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/cargo build`
[01:16:33] thread 'http_auth_offered' panicked at 'called `Option::unwrap()` on a `None` value', /checkout/src/libcore/option.rs:335:20
[01:16:33] 
[01:16:33] 
[01:16:33] failures:
[01:16:33]     http_auth_offered
[01:16:33] 
[01:16:33] test result: FAILED. 2 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
[01:16:33] 
[01:16:33] error: test failed, to rerun pass '--test build-auth'
[01:16:33] 
[01:16:33] 
[01:16:33] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "-j" "4" "--target" "x86_64-unknown-linux-gnu" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/cargo/Cargo.toml"
[01:16:33] expected success, got: exit code: 101

@GuillaumeGomez
Copy link
Member Author

@bors: r=nrc

@bors
Copy link
Contributor

bors commented Aug 31, 2017

📌 Commit b501d00 has been approved by nrc

@bors
Copy link
Contributor

bors commented Aug 31, 2017

⌛ Testing commit b501d00 with merge 97b01ab...

bors added a commit that referenced this pull request Aug 31, 2017
Add warnings when rustdoc html rendering differs
@bors
Copy link
Contributor

bors commented Aug 31, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: nrc
Pushing 97b01ab to master...

@GuillaumeGomez
Copy link
Member Author

YEEEEEEEEEEEEEEEEES!!!!!

@GuillaumeGomez GuillaumeGomez deleted the rustdoc-html-diff branch August 31, 2017 12:19
nrc added a commit to nrc/rust that referenced this pull request Sep 1, 2017
This is just undoing changes from rust-lang#41991 because we are not running markdown rendering twice.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 16, 2018
Is it really time? Have our months, no, *years* of suffering come to an end? Are we finally able to cast off the pall of Hoedown? The weight which has dragged us down for so long?

-----

So, timeline for those who need to catch up:

* Way back in December 2016, [we decided we wanted to switch out the markdown renderer](rust-lang#38400). However, this was put on hold because the build system at the time made it difficult to pull in dependencies from crates.io.
* A few months later, in March 2017, [the first PR was done, to switch out the renderers entirely](rust-lang#40338). The PR itself was fraught with CI and build system issues, but eventually landed.
* However, not all was well in the Rustdoc world. During the PR and shortly after, we noticed [some differences in the way the two parsers handled some things](rust-lang#40912), and some of these differences were major enough to break the docs for some crates.
* A couple weeks afterward, [Hoedown was put back in](rust-lang#41290), at this point just to catch tests that Pulldown was "spuriously" running. This would at least provide some warning about spurious tests, rather than just breaking spontaneously.
* However, the problems had created enough noise by this point that just a few days after that, [Hoedown was switched back to the default](rust-lang#41431) while we came up with a solution for properly warning about the differences.
* That solution came a few weeks later, [as a series of warnings when the HTML emitted by the two parsers was semantically different](rust-lang#41991). But that came at a cost, as now rustdoc needed proc-macro support (the new crate needed some custom derives farther down its dependency tree), and the build system was not equipped to handle it at the time. It was worked on for three months as the issue stumped more and more people.
  * In that time, [bootstrap was completely reworked](rust-lang#43059) to change how it ordered compilation, and [the method by which it built rustdoc would change](rust-lang#43482), as well. This allowed it to only be built after stage1, when proc-macros would be available, allowing the "rendering differences" PR to finally land.
  * The warnings were not perfect, and revealed a few [spurious](rust-lang#44368) [differences](rust-lang#45421) between how we handled the renderers.
  * Once these were handled, [we flipped the switch to turn on the "rendering difference" warnings all the time](rust-lang#45324), in October 2017. This began the "warning cycle" for this change, and landed in stable in 1.23, on 2018-01-04.
  * Once those warnings hit stable, and after a couple weeks of seeing whether we would get any more reports than what we got from sitting on nightly/beta, [we switched the renderers](rust-lang#47398), making Pulldown the default but still offering the option to use Hoedown.

And that brings us to the present. We haven't received more new issues from this in the meantime, and the "switch by default" is now on beta. Our reasoning is that, at this point, anyone who would have been affected by this has run into it already.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.