Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve collapse toggle render (css) #42011

Merged
merged 1 commit into from
May 16, 2017
Merged

Conversation

rap2hpoutre
Copy link
Contributor

The [-] toggle for functions in docs seems too big. It's just an impression, but it's something I noticed long time ago (maybe I have bad taste). I never thought to fix it, but, today I think: "Ok, why not suggest it.". Feel free to close without explanation!

Preview changes below:

From this:

capture d ecran 2017-05-15 a 17 14 45

To this:

capture d ecran 2017-05-15 a 17 15 02

@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS.

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @frewsxcv (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@GuillaumeGomez
Copy link
Member

Seems like a good change, however:

screen shot 2017-05-15 at 18 12 03

It seems a bit too little in here. :p

@rap2hpoutre
Copy link
Contributor Author

rap2hpoutre commented May 15, 2017

@GuillaumeGomez Thank you! You are right! I just updated my PR to only match on h4 > .collapse-toggle, h3 > .collapse-toggle (for function declarations only). So there will be no improvement for the screenshot you sent, only what I pointed. Maybe we could think at this part after. I have some other improvements in mind but I don't want to mess up this PR.

@GuillaumeGomez
Copy link
Member

Great, thanks! And yes please keep your changes into different PRs so it makes reviewers' life simpler. 😉

Also, can you squash your commits please? Once done, I'll merge. (and comment on the PR once done so I'm notified.)

@rap2hpoutre
Copy link
Contributor Author

@GuillaumeGomez Done! Thanks!

@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented May 16, 2017

📌 Commit 7a50784 has been approved by GuillaumeGomez

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 16, 2017
improve collapse toggle render (css)

The `[-]` toggle for functions in docs _seems_ too big. It's just an impression, but it's something I noticed long time ago (maybe I have bad taste). I never thought to fix it, but, today I think: "Ok, why not suggest it.". Feel free to close without explanation!

Preview changes below:

From this:

<img width="1003" alt="capture d ecran 2017-05-15 a 17 14 45" src="https://cloud.githubusercontent.com/assets/1575946/26064816/5c84de86-3992-11e7-976b-41c625cace0f.png">

To this:

<img width="996" alt="capture d ecran 2017-05-15 a 17 15 02" src="https://cloud.githubusercontent.com/assets/1575946/26064854/78325dac-3992-11e7-88f6-2c43db43421c.png">
@arielb1 arielb1 added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 16, 2017
bors added a commit that referenced this pull request May 16, 2017
Rollup of 8 pull requests

- Successful merges: #41489, #41982, #41994, #41995, #42001, #42005, #42011, #42028
- Failed merges:
@bors bors merged commit 7a50784 into rust-lang:master May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants