Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] backports #42161

Merged
merged 3 commits into from
May 23, 2017
Merged

[beta] backports #42161

merged 3 commits into from
May 23, 2017

Conversation

brson
Copy link
Contributor

@brson brson commented May 23, 2017

Bumps the version so we get a new beta.

@sfackler libs backports here

@nikomatsakis there are several other nominated PRs that don't cherry-pick cleanly: https://github.com/rust-lang/rust/pulls?q=is%3Apr+label%3Abeta-nominated+is%3Aclosed. Can you take a look or recruit someone else to?

r? @alexcrichton

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@alexcrichton
Copy link
Member

@bors: r+ p=1

@bors
Copy link
Contributor

bors commented May 23, 2017

📌 Commit 61063b0 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented May 23, 2017

⌛ Testing commit 61063b0 with merge 71e7c7e...

@bors
Copy link
Contributor

bors commented May 23, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

@Mark-Simulacrum
Copy link
Member

@bors p=20 (above rollup because beta branches soonish)

@Mark-Simulacrum
Copy link
Member

No, bors, I really did mean p=20, not rollup...

@bors p=20

@Mark-Simulacrum
Copy link
Member

@bors p=20

@Mark-Simulacrum
Copy link
Member

@bors -rollup

I think this is the syntax I might've seen @steveklabnik use.

@Mark-Simulacrum
Copy link
Member

@bors rollup- p=20

@bors
Copy link
Contributor

bors commented May 23, 2017

⌛ Testing commit 61063b0 with merge 139d12f...

bors added a commit that referenced this pull request May 23, 2017
[beta] backports

- #42006
- #41904

Bumps the version so we get a new beta.

@sfackler libs backports here

@nikomatsakis there are several other nominated PRs that don't cherry-pick cleanly: https://github.com/rust-lang/rust/pulls?q=is%3Apr+label%3Abeta-nominated+is%3Aclosed. Can you take a look or recruit someone else to?

r? @alexcrichton
@bors
Copy link
Contributor

bors commented May 23, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 139d12f to beta...

@bors bors merged commit 61063b0 into rust-lang:beta May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants