Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hack around abysmally slow llvm clones #42211

Merged
merged 1 commit into from
May 25, 2017
Merged

Hack around abysmally slow llvm clones #42211

merged 1 commit into from
May 25, 2017

Conversation

aidanhs
Copy link
Member

@aidanhs aidanhs commented May 25, 2017

r? @Mark-Simulacrum

(don't r+ yet, let's see what travis says)

@kennytm
Copy link
Member

kennytm commented May 25, 2017

If we are gonna download a zip file, perhaps it is even faster to put it on S3 (as a future proposal if this PR is accepted).

@aidanhs
Copy link
Member Author

aidanhs commented May 25, 2017

@kennytm note that we'd then have to remember to upload it every time we update LLVM. This way it will 'just work'.

Also, github probably has pretty solid caching, I believe that's the point of the codeload.github.com domain.

@Mark-Simulacrum
Copy link
Member

@bors r+ p=100

@bors
Copy link
Contributor

bors commented May 25, 2017

📌 Commit 47f8b4a has been approved by Mark-Simulacrum

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 25, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42211 - aidanhs:aphs-llvm-clone-hacks, r=Ma…
d429b49 
…rk-Simulacrum

Hack around abysmally slow llvm clones

r? @Mark-Simulacrum

(don't r+ yet, let's see what travis says)
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 25, 2017
Merged
bors added a commit that referenced this pull request May 25, 2017
@bors
Auto merge of #42212 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
cf747fc 
Rollup of 15 pull requests

- Successful merges: #41980, #42071, #42120, #42134, #42141, #42142, #42149, #42150, #42159, #42177, #42186, #42191, #42195, #42198, #42211
- Failed merges:
@aidanhs aidanhs mentioned this pull request May 25, 2017
Closed
@bors
Copy link
Contributor

bors commented May 25, 2017

⌛ Testing commit 47f8b4a with merge cf747fc...

@bors bors merged commit 47f8b4a into rust-lang:master May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aidanhs @kennytm @Mark-Simulacrum @bors