Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce verbosity of build logs #42354

Merged
merged 2 commits into from
Jun 3, 2017
Merged

Conversation

Mark-Simulacrum
Copy link
Member

This does two separate things.

  • Sets sccache logging to warn instead of info.
  • Makes tests when running for a given PR (not on auto branch) quiet. (cc @eddyb)

r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+

Thanks @Mark-Simulacrum!

@bors
Copy link
Contributor

bors commented Jun 1, 2017

📌 Commit 56f448d has been approved by alexcrichton

@alexcrichton alexcrichton added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 1, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Jun 1, 2017
When `--quiet` is passed to rustbuild, suppress rustdoc test output unless
failure.

Added a `--quiet` flag to `tidy`, which suppresses the features table.

The actual `--quiet` flag is enabled in rust-lang#42354.

Since details of failed tests will still be printed, and the name of slow
tests taking >60 to runtime will also be printed, the debugging difficulty
caused by information loss should be minimal; but it is very worthwhile to
keep the log under 10000 lines on Travis CI so that common errors can be
spotted without reading the raw log.
@Mark-Simulacrum
Copy link
Member Author

Travis completed with 6,714 lines cleanly. This makes the build log nicely viewable!

@alexcrichton
Copy link
Member

I'd love to combine test suites as well if we can eventually, right now there's hundreds of "running {0,1} tests" for all the markdown files in doc that we test but getting that into one giant list of tests would be great!

@Mark-Simulacrum
Copy link
Member Author

@bors rollup

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 1, 2017
…=alexcrichton

Reduce verbosity of build logs

This does two separate things.
 - Sets sccache logging to warn instead of info.
 - Makes tests when running for a given PR (not on auto branch) quiet. (cc @eddyb)

r? @alexcrichton
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 1, 2017
…=alexcrichton

Reduce verbosity of build logs

This does two separate things.
 - Sets sccache logging to warn instead of info.
 - Makes tests when running for a given PR (not on auto branch) quiet. (cc @eddyb)

r? @alexcrichton
@kennytm
Copy link
Member

kennytm commented Jun 2, 2017

So the rollup build #42367 has failed because the emscripten build has no output in 30 minutes during run-pass test.

I've checked the last successful auto build, the emscripten run-pass test,

[00:52:59] Check compiletest suite=run-pass mode=run-pass (x86_64-unknown-linux-gnu -> asmjs-unknown-emscripten)
...
[01:41:24] test result: ok. 2564 passed; 0 failed; 139 ignored; 0 measured; 0 filtered out
[01:41:24] 
[01:41:24] 	finished in 2904.985

the whole thing runs in 48m 25s. So indeed if the output is not flushed, Travis will normally cancel the job.

Since stamp won't print anything until seeing a \n, the quiet test should output a \n every 120 dots or so.

(Is it expected that emscripten is so slow? The run-pass test for x86_64 only runs for 6m 42s. The cost of asm.js is 7× native?)

@Mark-Simulacrum
Copy link
Member Author

@bors r-

I'll investigate what we can do. Might be worth just not having stamp for PR builds...

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jun 2, 2017

📌 Commit 3447aa7 has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 3, 2017
…=alexcrichton

Reduce verbosity of build logs

This does two separate things.
 - Sets sccache logging to warn instead of info.
 - Makes tests when running for a given PR (not on auto branch) quiet. (cc @eddyb)

r? @alexcrichton
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 3, 2017
…=alexcrichton

Reduce verbosity of build logs

This does two separate things.
 - Sets sccache logging to warn instead of info.
 - Makes tests when running for a given PR (not on auto branch) quiet. (cc @eddyb)

r? @alexcrichton
bors added a commit that referenced this pull request Jun 3, 2017
Rollup of 5 pull requests

- Successful merges: #42353, #42354, #42363, #42368, #42382
- Failed merges:
@bors bors merged commit 3447aa7 into rust-lang:master Jun 3, 2017
@Mark-Simulacrum Mark-Simulacrum deleted the reduce-verbosity branch June 8, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants