Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fail in case nothing to run was found #43145

Merged
merged 1 commit into from
Jul 15, 2017
Merged

fail in case nothing to run was found #43145

merged 1 commit into from
Jul 15, 2017

Conversation

GuillaumeGomez
Copy link
Member

Mark-Simulacrum
Mark-Simulacrum reviewed Jul 10, 2017
View reviewed changes
src/bootstrap/step.rs Outdated
.map(|priority| (rule, priority))
}
}).collect();

if rules.is_empty() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, this is good, but I sort of expected we'd go a step further and check that every path matched with a rule... I might be wrong, but I think that should always be the case. cc @alexcrichton -- can you confirm we should match all paths?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, seems fine.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of paths and a lot of them aren't doing anything, so I'm sure this is a good idea...

@kennytm
Copy link
Member

kennytm commented Jul 10, 2017

make prepare failed, because, well

prepare:
    $(Q)$(BOOTSTRAP) build nonexistent/path/to/trigger/cargo/metadata

Please either special-case "nonexistent/path/to/trigger/cargo/metadata" or change make prepare not based on a non-existing path.

@GuillaumeGomez
Copy link
Member Author

Fixed make prepare.

@arielb1 arielb1 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 11, 2017
@GuillaumeGomez
Copy link
Member Author

Ping in here.

@Mark-Simulacrum
Copy link
Member

Alright, I'll accept that stopgap for now, though we should look into a better solution. It's fine for the time being I think.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 13, 2017

📌 Commit 0cf8f85 has been approved by Mark-Simulacrum

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jul 15, 2017
@frewsxcv
Rollup merge of rust-lang#43145 - GuillaumeGomez:build-error-if-nothi…
c3a8347 
…ng, r=Mark-Simulacrum

fail in case nothing to run was found

Fixes rust-lang#43121.

r? @Mark-Simulacrum
@frewsxcv frewsxcv mentioned this pull request Jul 15, 2017
Merged
bors added a commit that referenced this pull request Jul 15, 2017
@bors
Auto merge of #43246 - frewsxcv:rollup, r=frewsxcv
a783fe2 
Rollup of 8 pull requests

- Successful merges: #43074, #43145, #43159, #43202, #43222, #43228, #43229, #43240
- Failed merges:
@bors bors merged commit 0cf8f85 into rust-lang:master Jul 15, 2017
@bors
Copy link
Contributor

bors commented Jul 15, 2017

⌛ Testing commit 0cf8f85 with merge a783fe2...

@bors
Copy link
Contributor

bors commented Jul 15, 2017

☔ The latest upstream changes (presumably #43246) made this pull request unmergeable. Please resolve the merge conflicts.

@Mark-Simulacrum
Copy link
Member

Bors? You okay?

@bors r-

@GuillaumeGomez GuillaumeGomez deleted the build-error-if-nothing branch July 16, 2017 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton left review comments

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @kennytm @Mark-Simulacrum @bors @alexcrichton @arielb1