Implement RefCell::replace and RefCell::swap
#43574
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
frewsxcv
added
the
T-libs-api
src/libcore/cell.rs
Outdated
| /// | ||
| /// This function corresponds to [`std::mem::replace`](../mem/fn.replace.html). | ||
| /// | ||
| /// # Example |
There was a problem hiding this comment.
src/libcore/cell.rs
Outdated
| /// | ||
| /// This function corresponds to [`std::mem::swap`](../mem/fn.swap.html). | ||
| /// | ||
| /// # Example |
|
Those problems are fixed now. |
aidanhs
added
the
S-waiting-on-review
|
r? @sfackler |
| /// | ||
| /// # Panics | ||
| /// | ||
| /// This function will panic if the `RefCell` has any outstanding borrows, |
There was a problem hiding this comment.
There is only one RefCell involved in a RefCell::replace. This is different from RefCell::swap, which does actually involve two of them.
There was a problem hiding this comment.
Oops, yeah, I thought this was below.
| @@ -543,6 +543,59 @@ impl<T> RefCell<T> { | |||
| debug_assert!(self.borrow.get() == UNUSED); | |||
| unsafe { self.value.into_inner() } | |||
| } | |||
|
|
|||
| /// Replaces the wrapped value with a new one, returning the old value, | |||
There was a problem hiding this comment.
I wonder if the docs should mention that these are simply convenience functions for their one-liner implementations? I wouldn't want people thinking that they're more "magical" than they really are. Thoughts @steveklabnik? Not sure if we do something similar elsewhere.
|
ping @sfackler, looks like this is ready for your rereview! |
|
@bors r+ |
|
📌 Commit 846d373 has been approved by |
Implement `RefCell::replace` and `RefCell::swap` Tracking issue: #43570
|
☀️ Test successful - status-appveyor, status-travis |
Tracking issue: #43570