-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated release notes for 1.20 #43627
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
RELEASES.md
Outdated
|
||
- [Functions with `'static` in their return types will now not be as usable as | ||
if they were using lifetime parameters instead.][42417] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#42431 should be a compatibility note. Previously NaN returns false for both is_sign_positive
and is_sign_negative
, and now they take the sign of NaN into account (following IEEE-754 definition). Code relying on the old behavior will be broken.
RELEASES.md
Outdated
NaN.][42431] | ||
- [allow messages in the `unimplemented!()` macro.][42155] | ||
ie. `unimplemented!("Waiting for 1.21 to be stable")` | ||
- [support pub(restricted) in thread_local! (round 2)][43185] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to say "round 2" :)
RELEASES.md
Outdated
- [Reimplemented `{f32, f64}::{min, max}` in Rust instead of using CMath.][42430] | ||
- [Skip the main thread's manual stack guard on Linux][43072] | ||
- [Iterator::nth for `ops::{Range, RangeFrom}` is now done in O(1) time][43077] | ||
- [`#cfg[align(N)]` attribute max number is now 2^31 - 1.][43097] This was |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#[repr(align(N))]
, not "cfg".
RELEASES.md
Outdated
Compiler | ||
-------- | ||
|
||
- [Struct fields are now properly to the expected field type.][42807] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it should be "Struct fields are now properly coerced..."
RELEASES.md
Outdated
- [Cargo API token location moved from `~/.cargo/config` to | ||
`~/cargo/credentials`.][cargo/3978] | ||
- [Cargo will now build multiple `main.rs` binaries in different | ||
directories.][cargo/4214] ie. Having `src/server/main.rs` and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh this is actually a little different than mentioned here. The change here was to infer src/bin/$binary_name/main.rs
automatically as producign a $binary_name
binary. Previously we'd just recognie src/bin/*.rs
, but now we're also recognizing src/bin/*/main.rs
Looking great tome, thanks so much again for tackling this @Aaronepower! I don't mind r+'ing soon in the release cycle this time, that way we can edit it in-tree via PRs! |
@alexcrichton I've updated the wording of the Cargo change. Let me know if it's contains any more inaccuracies! |
@bors: r+ Looks great! Thanks again @Aaronepower! |
📌 Commit 8908718 has been approved by |
Updated release notes for 1.20 [Rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md)
☀️ Test successful - status-appveyor, status-travis |
Rendered