Rollup of 6 pull requests #43872
Merged
Rollup of 6 pull requests #43872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
frewsxcv
commented
Aug 15, 2017
frewsxcv
commented
- Successful merges: Instant is monotonically nondecreasing #43756, Write the "passes" chapter of the rustdoc book #43790, Remove my mailmap entry. #43846, Rewrite/reorganize docs for stack size/thread names for spawned threads. #43848, rustdoc: put auto-hidden docblock labels in line with the toggle #43862, Add missing newline in Deref docs to fix rendering #43868
- Failed merges:
We don't want to guarantee that `Instant::now() != Instant::now()` is always true since that depends on the speed of the processor and the resolution of the clock.
* Moves docs about stack size and thread naming from `Builder` to the `std::thread` module * Adds more links to the new module-level documentation * Mentions the 2 MiB stack size default, but indicate it's subject to change Fixes rust-lang#43805.
…lexcrichton Instant is monotonically nondecreasing We don't want to guarantee that `Instant::now() != Instant::now()` is always true since that depends on the speed of the processor and the resolution of the clock.
…tMisdreavus Write the "passes" chapter of the rustdoc book cc rust-lang#42322 r? @rust-lang/docs
…imulacrum Remove my mailmap entry. I no longer want this mailmap entry for myself.
…etMisdreavus Rewrite/reorganize docs for stack size/thread names for spawned threads. * Moves docs about stack size and thread naming from `Builder` to the `std::thread` module * Adds more links to the new module-level documentation * Mentions the 2 MiB stack size default, but indicate it's subject to change Fixes rust-lang#43805.
…e, r=GuillaumeGomez rustdoc: put auto-hidden docblock labels in line with the toggle before:  after:  (images taken from `std::heap::AllocErr`)
Add missing newline in Deref docs to fix rendering Fixes rust-lang#43866. (Verified locally.) r? @steveklabnik
|
Some changes occurred in HTML/CSS. |
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors r+ p=10 |
|
📌 Commit 1259db2 has been approved by |
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.