Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uplift fix for include! in doc tests to beta #43922

Merged
merged 2 commits into from
Aug 19, 2017
Merged

Uplift fix for include! in doc tests to beta #43922

merged 2 commits into from
Aug 19, 2017

Conversation

nrc
Copy link
Member

@nrc nrc commented Aug 17, 2017

Uplift #43782 to beta. Fixes #43153.

r? @alexcrichton

(approved by @rust-lang/dev-tools )

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@nrc nrc changed the title Beta Uplift fix for include! in doc tests to beta Aug 17, 2017
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Aug 17, 2017

📌 Commit b64b5de has been approved by alexcrichton

@GuillaumeGomez
Copy link
Member

Should we make this change on nightly as well? (I don't know if there is a backport strategy or equivalent.)

@nrc
Copy link
Member Author

nrc commented Aug 17, 2017

@GuillaumeGomez #43782 is this change on nightly.

@GuillaumeGomez
Copy link
Member

Oh I see, great!

@bors
Copy link
Contributor

bors commented Aug 18, 2017

⌛ Testing commit b64b5de with merge d7bfbd1c47552d12f985113f6e3edcbbc6277edd...

@aidanhs
Copy link
Member

aidanhs commented Aug 18, 2017

@bors retry
(prioritise rollup)

@bors
Copy link
Contributor

bors commented Aug 19, 2017

⌛ Testing commit b64b5de with merge ec81f5dc5bd3414b7084a74dd94bf8933886a5c8...

@bors
Copy link
Contributor

bors commented Aug 19, 2017

💔 Test failed - status-appveyor

@kennytm
Copy link
Member

kennytm commented Aug 19, 2017

@bors retry #43985

@bors
Copy link
Contributor

bors commented Aug 19, 2017

⌛ Testing commit b64b5de with merge 9e012f4...

bors added a commit that referenced this pull request Aug 19, 2017
Uplift fix for include! in doc tests to beta

Uplift #43782 to beta. Fixes #43153.

r? @alexcrichton

(approved by @rust-lang/dev-tools )
@bors
Copy link
Contributor

bors commented Aug 19, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 9e012f4 to beta...

@bors bors merged commit b64b5de into rust-lang:beta Aug 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants