Rollup of 4 pull requests #43980
Closed
Rollup of 4 pull requests #43980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aidanhs
commented
Aug 18, 2017
aidanhs
commented
- Successful merges: Minor rewrite of char primitive unicode intro. #43919, Upgrade a comment to a doc comment #43936, Add x86_64-unknown-redox to build manifest target list #43950, Missing links #43978
- Failed merges:
Opened primarily to address rust-lang#36998.
…=QuietMisdreavus Minor rewrite of char primitive unicode intro. Opened primarily to address rust-lang#36998. Despite my love for emoji, the heart example is a little confusing because both heart characters start with the same code point and there can be stark rendering differences across browsers. I also spelled out what each of the code points is in the code block, which (hopefully) sheds light why one character is one code point while the other is two. Very much open to suggestion and improvements. I'm pretty tired when I wrote this so I might wake up and realize that this is making things more confusing 😅
Upgrade a comment to a doc comment r? @alexcrichton cc @bjorn3
Add x86_64-unknown-redox to build manifest target list This should fix the issue of `x86_64-unknown-redox` not being available for `rustup target add`
…wsxcv Missing links r? @rust-lang/docs
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=1 |
|
📌 Commit 92a5cd9 has been approved by |
|
💔 Test failed - status-travis |
|
Merge got stuck by #40672. The PR travis build is a live example of the problem I've sent to travis, so don't close this PR for now (not sure if that will auto-cancel the build). |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.