-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy all AsciiExt
methods to the primitive types directly in order to deprecate it later
#44042
Merged
bors
merged 16 commits into
rust-lang:master
from
LukasKalbertodt:ascii-methods-on-instrinsics
Nov 5, 2017
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
d3f2be4
Add all methods of AsciiExt to u8 directly
LukasKalbertodt 04070d1
Make ascii methods on u8 insta-stable
LukasKalbertodt 5061c9f
Revert signature of eq_ignore_ascii_case() to original
LukasKalbertodt d425f8d
Copy `AsciiExt` methods to `char` directly
LukasKalbertodt 6f55568
Use direct implementation on u8/char to implement AsciiExt
LukasKalbertodt a527762
Remove examples in doc-comments of `AsciiExt` methods
LukasKalbertodt 3b13b66
Tweak documentation for `u8::eq_ignore_ascii_case()`
LukasKalbertodt f373916
Add missing space in match arm
LukasKalbertodt 8a4fa74
Fix lists in doc comments for ascii methods of u8 and char
LukasKalbertodt 9e441c7
Add a lang item to allow `impl [u8] {…}` in the standard library
SimonSapin 5a1d11a
Copy `AsciiExt` methods to `[u8]` directly
LukasKalbertodt 1916e3c
Copy `AsciiExt` methods to `str` directly
LukasKalbertodt da57580
Remove unused AsciiExt imports and fix tests related to ascii methods
LukasKalbertodt 259c125
Mark several ascii methods as unstable again
LukasKalbertodt deb7360
Remove import of now unused AsciiExt
LukasKalbertodt ea55596
Relax #[deny(warnings)] in some crate for cargotest
LukasKalbertodt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance we can move this and similar non-alloc methods to
libcore
?With
to_*_lowercase()/_uppercase()
methods missing inlibcore
, this is the only method available for case-insensitive string comparison, which is a common operation in many application, even embedded.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this would be good to have, but it’s tricky. I’ve opened #45803.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#49896 does this (though #49698 also made the Unicode
to_lowercase
andto_uppercase
available in libcore).