-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 9 pull requests #44155
Rollup of 9 pull requests #44155
Commits on Jul 23, 2017
-
Configuration menu - View commit details
-
Copy full SHA for c7168d3 - Browse repository at this point
Copy the full SHA c7168d3View commit details
Commits on Jul 25, 2017
-
Configuration menu - View commit details
-
Copy full SHA for eeb16a1 - Browse repository at this point
Copy the full SHA eeb16a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c18c1d5 - Browse repository at this point
Copy the full SHA c18c1d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51e92bb - Browse repository at this point
Copy the full SHA 51e92bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2cc7286 - Browse repository at this point
Copy the full SHA 2cc7286View commit details
Commits on Aug 1, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 24abea9 - Browse repository at this point
Copy the full SHA 24abea9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca684a6 - Browse repository at this point
Copy the full SHA ca684a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59cff34 - Browse repository at this point
Copy the full SHA 59cff34View commit details
Commits on Aug 27, 2017
-
Fail ./x.py on invalid command
Make the ./x.py script fail when run with an invalid command, like: ./x.py nonsense This helps in case of chaining multiple runs, eg.: ./x.py biuld && ./x.py test
Configuration menu - View commit details
-
Copy full SHA for 6fc35de - Browse repository at this point
Copy the full SHA 6fc35deView commit details
Commits on Aug 28, 2017
-
bootstrap: remove unneeded extern crate
The crate itself is internally referenced by serde_derive.
Configuration menu - View commit details
-
Copy full SHA for 45d31ac - Browse repository at this point
Copy the full SHA 45d31acView commit details -
un-regress behavior of
unused_results
lint for booleansThis, as rust-lang#43813, is due to the author of rust-lang#43728 (specifically, 3645b06) being a damnably contemptible fool. Before this entire fiasco, we would return early from the unusedness late lints pass if the type of the expression within the `hir::StmtSemi` was `!`, `()`, or a boolean: these types would never get to the point of being marked as unused results. That is, until the dunce who somehow (!?) came to be trusted with the plum responsibility of implementing RFC 1940 (`#[must_use]` for functions) went and fouled everything up, removing the early returns based on the (stupid) thought that there would be no harm in it, since we would need to continue to check these types being returned from must_use functions (which was true for the booleans, at least). But there was harm—harm that any quarter-way-competent programmer would have surely forseen! For after the new functional-must-use checks, there was nothing to stop the previously-returned-early types from falling through to be marked by the unused-results lint!—a monumentally idiotic error that has cost the project tens of precious developer- and reviewer-minutes dealing with the fallout here and in rust-lang#43813. If 3645b06 is representative of the standard of craftsmanship the rising generation of software engineers holds themselves to, I weep for the future of our technological civilization. Resolves rust-lang#44119.
Configuration menu - View commit details
-
Copy full SHA for cc5ea04 - Browse repository at this point
Copy the full SHA cc5ea04View commit details -
compiletest: Change Config comments to doc comments
Thomas Jespersen committedAug 28, 2017 Configuration menu - View commit details
-
Copy full SHA for 2bffa31 - Browse repository at this point
Copy the full SHA 2bffa31View commit details -
Rewrite
std::net::ToSocketAddrs
doc examples.in particular: * show how to create an iterator that yields multiple socket addresses * show more failing scenarios
Configuration menu - View commit details
-
Copy full SHA for 10bd39e - Browse repository at this point
Copy the full SHA 10bd39eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f50bf86 - Browse repository at this point
Copy the full SHA f50bf86View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c28740 - Browse repository at this point
Copy the full SHA 5c28740View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4cd5314 - Browse repository at this point
Copy the full SHA 4cd5314View commit details
Commits on Aug 29, 2017
-
rustbuild: Fix dependencies of build-manifest
No need to depend on librustc! All we need is libstd Closes rust-lang#44140
Configuration menu - View commit details
-
Copy full SHA for ecd127d - Browse repository at this point
Copy the full SHA ecd127dView commit details -
Rollup merge of rust-lang#43426 - qnighy:intercrate-ambiguity-hints, …
…r=nikomatsakis Add hints when intercrate ambiguity causes overlap. I'm going to tackle rust-lang#23980. # Examples ## Trait impl overlap caused by possible downstream impl ```rust trait Foo<X> {} trait Bar<X> {} impl<X, T> Foo<X> for T where T: Bar<X> {} impl<X> Foo<X> for i32 {} fn main() {} ``` ``` error[E0119]: conflicting implementations of trait `Foo<_>` for type `i32`: --> test1.rs:4:1 | 3 | impl<X, T> Foo<X> for T where T: Bar<X> {} | ------------------------------------------ first implementation here 4 | impl<X> Foo<X> for i32 {} | ^^^^^^^^^^^^^^^^^^^^^^^^^ conflicting implementation for `i32` | = note: downstream crates may implement Bar error: aborting due to previous error ``` ## Trait impl overlap caused by possible upstream update ```rust trait Foo {} impl<T> Foo for T where T: ::std::fmt::Octal {} impl Foo for () {} fn main() {} ``` ``` error[E0119]: conflicting implementations of trait `Foo` for type `()`: --> test2.rs:3:1 | 2 | impl<T> Foo for T where T: ::std::fmt::Octal {} | ----------------------------------------------- first implementation here 3 | impl Foo for () {} | ^^^^^^^^^^^^^^^^^^ conflicting implementation for `()` | = note: upstream crates may add new impl for std::fmt::Octal in future versions error: aborting due to previous error ``` ## Inherent impl overlap caused by possible downstream impl ```rust trait Bar<X> {} struct A<T, X>(T, X); impl<X, T> A<T, X> where T: Bar<X> { fn f(&self) {} } impl<X> A<i32, X> { fn f(&self) {} } fn main() {} ``` ``` error[E0592]: duplicate definitions with name `f` --> test3.rs:4:38 | 4 | impl<X, T> A<T, X> where T: Bar<X> { fn f(&self) {} } | ^^^^^^^^^^^^^^ duplicate definitions for `f` 5 | impl<X> A<i32, X> { fn f(&self) {} } | -------------- other definition for `f` | = note: downstream crates may implement Bar error: aborting due to previous error ``` ## Inherent impl overlap caused by possible upstream update ```rust struct A<T>(T); impl<T> A<T> where T: ::std::fmt::Octal { fn f(&self) {} } impl A<()> { fn f(&self) {} } fn main() {} ``` ``` error[E0592]: duplicate definitions with name `f` --> test4.rs:3:43 | 3 | impl<T> A<T> where T: ::std::fmt::Octal { fn f(&self) {} } | ^^^^^^^^^^^^^^ duplicate definitions for `f` 4 | impl A<()> { fn f(&self) {} } | -------------- other definition for `f` | = note: upstream crates may add new impl for std::fmt::Octal in future versions error: aborting due to previous error ```
Configuration menu - View commit details
-
Copy full SHA for e773897 - Browse repository at this point
Copy the full SHA e773897View commit details -
Rollup merge of rust-lang#44117 - frewsxcv:frewsxcv-to-socket-addrs-e…
…xamples, r=QuietMisdreavus Rewrite `std::net::ToSocketAddrs` doc examples. in particular: * show how to create an iterator that yields multiple socket addresses * show more failing scenarios done this as preliminary work while investigating rust-lang#22569 note: i haven't run doc tests on my machine for this, so would be good to confirm CI passes before approving
Configuration menu - View commit details
-
Copy full SHA for bd093cd - Browse repository at this point
Copy the full SHA bd093cdView commit details -
Rollup merge of rust-lang#44121 - ishitatsuyuki:bootstrap-deps-purge,…
… r=Mark-Simulacrum bootstrap: remove unneeded extern crate The crate itself is internally referenced by serde_derive.
Configuration menu - View commit details
-
Copy full SHA for 18feb58 - Browse repository at this point
Copy the full SHA 18feb58View commit details -
Rollup merge of rust-lang#44122 - zackmdavis:booleans_were_not_unused…
…_results, r=eddyb un-regress behavior of `unused_results` lint for booleans Resolves rust-lang#44119.
Configuration menu - View commit details
-
Copy full SHA for eefe818 - Browse repository at this point
Copy the full SHA eefe818View commit details -
Rollup merge of rust-lang#44126 - laumann:config-doc-comments, r=niko…
…matsakis compiletest: Change Config comments to doc comments I plan to make the same change in compiletest-rs, to have some documentation in [the docs](https://docs.rs/compiletest_rs/0.2.9/compiletest_rs/common/struct.Config.html).
Configuration menu - View commit details
-
Copy full SHA for f5c6d14 - Browse repository at this point
Copy the full SHA f5c6d14View commit details -
Rollup merge of rust-lang#44134 - vorner:x-py-unknown-cmd, r=nikomats…
…akis Fail ./x.py on invalid command Make the ./x.py script fail when run with an invalid command, like: ``` ./x.py nonsense ``` This helps in case of chaining multiple runs, eg.: ``` ./x.py biuld && ./x.py test ```
Configuration menu - View commit details
-
Copy full SHA for 3e2d5cb - Browse repository at this point
Copy the full SHA 3e2d5cbView commit details -
Rollup merge of rust-lang#44135 - GuillaumeGomez:fix-css-links, r=Qui…
…etMisdreavus Fix invalid linker position Fixes rust-lang#44120. Result isn't "optimal" though because there are spaces at the end of some lines.
Configuration menu - View commit details
-
Copy full SHA for efa27ac - Browse repository at this point
Copy the full SHA efa27acView commit details -
Rollup merge of rust-lang#44138 - steveklabnik:rustdoc-deprecations, …
…r=Manishearth Deprecate several flags in rustdoc Part of rust-lang#44136 cc @rust-lang/dev-tools @rust-lang/docs This is a very basic PR to start deprecating some flags; `rustdoc` doesn't really have fancy output options like `rustc` does, so I went with `eprintln!`. Happy to change it if people feel that's not appropriate. Also, I have no idea if we can or should write tests here, so I didn't try. If someone feels strongly about it, then let's do it, but given that the only outcome here is a side effect...
Configuration menu - View commit details
-
Copy full SHA for 44e03a4 - Browse repository at this point
Copy the full SHA 44e03a4View commit details -
Rollup merge of rust-lang#44144 - alexcrichton:faster-hash-and-sign, …
…r=Mark-Simulacrum rustbuild: Fix dependencies of build-manifest No need to depend on librustc! All we need is libstd Closes rust-lang#44140
Configuration menu - View commit details
-
Copy full SHA for 00656fe - Browse repository at this point
Copy the full SHA 00656feView commit details