Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand on using rustup custom toolchains in CONTRIBUTING.md #44194

Conversation

QuietMisdreavus
Copy link
Member

fixes #42484

Should i include more notes about how to use a local build without rustup? It can kinda feel like a cop-out otherwise. Other means that come to mind are setting $RUSTC directly and fully installing it.

cc @rust-lang/docs

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@GuillaumeGomez
Copy link
Member

👍

@aidanhs aidanhs added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 31, 2017
@aturon
Copy link
Member

aturon commented Sep 1, 2017

Awesome, thank you!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Sep 1, 2017

📌 Commit 1615d35 has been approved by aturon

@bors
Copy link
Contributor

bors commented Sep 4, 2017

⌛ Testing commit 1615d35 with merge de4e3441fc4a8d6ad9dff83e1359f43749d94754...

@bors
Copy link
Contributor

bors commented Sep 4, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Sep 4, 2017

@bors retry

check i686-apple-darwin failed, LLDB segfault.

[01:45:44] ---- [debuginfo-lldb] debuginfo-lldb/static-method-on-struct-and-enum.rs stdout ----
[01:45:44] 	NOTE: compiletest thinks it is using LLDB version 360
[01:45:44] 
[01:45:44] error: Error while running LLDB
[01:45:44] status: signal: 11
[01:45:44] command: "/usr/bin/python" "/Users/travis/build/rust-lang/rust/src/etc/lldb_batchmode.py" "/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/test/debuginfo/static-method-on-struct-and-enum.stage2-i686-apple-darwin" "/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/test/debuginfo/static-method-on-struct-and-enum.debugger.script"
[01:45:44] stdout:
[01:45:44] ------------------------------------------
[01:45:44] LLDB batch-mode script
[01:45:44] ----------------------
[01:45:44] Debugger commands script is '/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/test/debuginfo/static-method-on-struct-and-enum.debugger.script'.
[01:45:44] Target executable is '/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/test/debuginfo/static-method-on-struct-and-enum.stage2-i686-apple-darwin'.
[01:45:44] Current working directory is '/Users/travis/build/rust-lang/rust'
[01:45:44] Creating a target for '/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/test/debuginfo/static-method-on-struct-and-enum.stage2-i686-apple-darwin'
[01:45:44] settings set auto-confirm true
[01:45:44] 
[01:45:44] version
[01:45:44] lldb-360.1.70 
[01:45:44] command script import /Users/travis/build/rust-lang/rust/./src/etc/lldb_rust_formatters.py
[01:45:44] type summary add --no-value --python-function lldb_rust_formatters.print_val -x ".*" --category Rust
[01:45:44] type category enable Rust
[01:45:44] 
[01:45:44] breakpoint set --file 'static-method-on-struct-and-enum.rs' --line 66
[01:45:44] Breakpoint 1: where = static-method-on-struct-and-enum.stage2-i686-apple-darwin`static_method_on_struct_and_enum::{{impl}}::static_method + 36 at static-method-on-struct-and-enum.rs:66, address = 0x00001d14 
[01:45:44] breakpoint set --file 'static-method-on-struct-and-enum.rs' --line 80
[01:45:44] Breakpoint 2: where = static-method-on-struct-and-enum.stage2-i686-apple-darwin`static_method_on_struct_and_enum::{{impl}}::static_method + 50 at static-method-on-struct-and-enum.rs:80, address = 0x00001d82 
[01:45:44] quit
[01:45:44] 
[01:45:44] 
[01:45:44] ------------------------------------------
[01:45:44] stderr:
[01:45:44] ------------------------------------------
[01:45:44] 
[01:45:44] ------------------------------------------
[01:45:44] 
[01:45:44] thread '[debuginfo-lldb] debuginfo-lldb/static-method-on-struct-and-enum.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:2435:8
[01:45:44] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:45:44] 
[01:45:44] 
[01:45:44] failures:
[01:45:44]     [debuginfo-lldb] debuginfo-lldb/static-method-on-struct-and-enum.rs
[01:45:44] 
[01:45:44] test result: �[31mFAILED�(B�[m. 97 passed; 1 failed; 10 ignored; 0 measured; 0 filtered out
[01:45:44] 
[01:45:44] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:323:21

@bors
Copy link
Contributor

bors commented Sep 4, 2017

⌛ Testing commit 1615d35 with merge 088216f...

bors added a commit that referenced this pull request Sep 4, 2017
…led-thing, r=aturon

expand on using rustup custom toolchains in CONTRIBUTING.md

fixes #42484

Should i include more notes about how to use a local build *without* rustup? It can kinda feel like a cop-out otherwise. Other means that come to mind are setting `$RUSTC` directly and fully installing it.

cc @rust-lang/docs
@bors
Copy link
Contributor

bors commented Sep 4, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: aturon
Pushing 088216f to master...

@bors bors merged commit 1615d35 into rust-lang:master Sep 4, 2017
@QuietMisdreavus QuietMisdreavus deleted the hey-how-do-i-use-this-new-fangled-thing branch February 26, 2018 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add information on how to run builds to CONTRIBUTING.md
7 participants