Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove or encapsulate the remaining non-query data in tcx #44501

Merged
merged 10 commits into from
Oct 18, 2017
Merged

remove or encapsulate the remaining non-query data in tcx #44501

merged 10 commits into from
Oct 18, 2017

Commits on Oct 16, 2017

  1. refactor inhabitedness to have clearer public entry points

    @nikomatsakis
    nikomatsakis committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    a5673de View commit details
    Browse the repository at this point in the history

  2. restructure the public inhabitedness APIs and remove the cache 

    The cache was broken anyhow and this computation doesn't look that
expensive. These public accessors could potentially become queries,
but we'd have to add some more complex logic around lift. I'd prefer
to have some test cases to profile with before doing that.

Fixes rust-lang#44402.
    @nikomatsakis
    nikomatsakis committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    5c26509 View commit details
    Browse the repository at this point in the history

  3. invoke const only on body-ids

    @nikomatsakis
    nikomatsakis committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    807e157 View commit details
    Browse the repository at this point in the history

  4. convert constant promotion into a query

    @nikomatsakis
    nikomatsakis committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    0f568e2 View commit details
    Browse the repository at this point in the history

  5. add a function for testing if a ty is uninhabited from all modules 

    Desired by miri.
    @nikomatsakis
    nikomatsakis committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    47449ea View commit details
    Browse the repository at this point in the history

  6. add some tips to CONTRIBUTING.md to help with debugging this problem

    @nikomatsakis
    nikomatsakis committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    09caa12 View commit details
    Browse the repository at this point in the history

  7. fix nits

    @nikomatsakis
    nikomatsakis committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    165cbce View commit details
    Browse the repository at this point in the history

  8. bump up the recursion limit

    @nikomatsakis
    nikomatsakis committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    0ae18a1 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2017

  1. make erase_regions use a query instead of an ad-hoc cache

    @nikomatsakis
    nikomatsakis committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    0e67d17 View commit details
    Browse the repository at this point in the history

  2. break clippy

    @nikomatsakis
    nikomatsakis committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    7715f97 View commit details
    Browse the repository at this point in the history