Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more links and put the link character to the left #44661

Merged
merged 1 commit into from
Sep 18, 2017
Merged

Add more links and put the link character to the left #44661

merged 1 commit into from
Sep 18, 2017

Conversation

GuillaumeGomez
Copy link
Member

r? @QuietMisdreavus

And of course, a few screenshots:

screen shot 2017-09-17 at 22 08 46

screen shot 2017-09-17 at 22 09 47

screen shot 2017-09-17 at 22 10 56

@QuietMisdreavus
Copy link
Member

So how does this look with the existing class="anchor" links? I see the new ones here put the anchor before the text in the header, but the previous ones had it after. Does the position: absolute in the CSS make it not matter?

@GuillaumeGomez
Copy link
Member Author

position: absolute; and left: ...px;.

@GuillaumeGomez
Copy link
Member Author

New screenshot as requested on IRC:

screen shot 2017-09-17 at 22 25 09

@QuietMisdreavus
Copy link
Member

r=me pending travis

@GuillaumeGomez
Copy link
Member Author

@bors: r=QuietMisdreavus

@bors
Copy link
Contributor

bors commented Sep 17, 2017

📌 Commit e47279f has been approved by QuietMisdreavus

@carols10cents carols10cents added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 18, 2017
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Sep 18, 2017
@alexcrichton
Rollup merge of rust-lang#44661 - GuillaumeGomez:more-links, r=QuietM…
8f998d3 
…isdreavus

Add more links and put the link character to the left

r? @QuietMisdreavus

And of course, a few screenshots:

<img width="1440" alt="screen shot 2017-09-17 at 22 08 46" src="https://user-images.githubusercontent.com/3050060/30524496-44a50208-9bf5-11e7-942e-a3707ba125c3.png">
<img width="1440" alt="screen shot 2017-09-17 at 22 09 47" src="https://user-images.githubusercontent.com/3050060/30524502-49068dbc-9bf5-11e7-8e59-ec38664e0e0f.png">
<img width="1440" alt="screen shot 2017-09-17 at 22 10 56" src="https://user-images.githubusercontent.com/3050060/30524503-491c8c34-9bf5-11e7-9ce5-f1bd5ef8600b.png">
@alexcrichton alexcrichton mentioned this pull request Sep 18, 2017
Closed
bors added a commit that referenced this pull request Sep 18, 2017
@bors
Auto merge of #44676 - alexcrichton:rollup, r=alexcrichton
4a8bc8a 
Rollup of 10 pull requests

- Successful merges: #44364, #44466, #44537, #44640, #44651, #44657, #44661, #44668, #44671, #44675
- Failed merges:
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Sep 18, 2017
@alexcrichton
Rollup merge of rust-lang#44661 - GuillaumeGomez:more-links, r=QuietM…
3bbe153 
…isdreavus

Add more links and put the link character to the left

r? @QuietMisdreavus

And of course, a few screenshots:

<img width="1440" alt="screen shot 2017-09-17 at 22 08 46" src="https://user-images.githubusercontent.com/3050060/30524496-44a50208-9bf5-11e7-942e-a3707ba125c3.png">
<img width="1440" alt="screen shot 2017-09-17 at 22 09 47" src="https://user-images.githubusercontent.com/3050060/30524502-49068dbc-9bf5-11e7-8e59-ec38664e0e0f.png">
<img width="1440" alt="screen shot 2017-09-17 at 22 10 56" src="https://user-images.githubusercontent.com/3050060/30524503-491c8c34-9bf5-11e7-9ce5-f1bd5ef8600b.png">
@alexcrichton alexcrichton mentioned this pull request Sep 18, 2017
Merged
bors added a commit that referenced this pull request Sep 18, 2017
@bors
Auto merge of #44678 - alexcrichton:rollup, r=alexcrichton
0701b37 
Rollup of 11 pull requests

- Successful merges: #44364, #44466, #44537, #44548, #44640, #44651, #44657, #44661, #44668, #44671, #44675
- Failed merges:
@bors bors merged commit e47279f into rust-lang:master Sep 18, 2017
@GuillaumeGomez GuillaumeGomez deleted the more-links branch September 19, 2017 07:50
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 19, 2017
Closed
@Manishearth Manishearth mentioned this pull request Sep 21, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@QuietMisdreavus QuietMisdreavus

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillaumeGomez @QuietMisdreavus @bors @carols10cents