Update docs for process::abort #44905
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
src/libstd/process.rs
Outdated
| /// This is in contrast to the default behaviour of [`panic!`] which unwinds | ||
| /// the current thread's stack and calls all destructors. | ||
| /// When `panic="abort"` is set, either as an argument to `rustc` or in a | ||
| /// crate's Cargo.toml, [`panic!`] and `abort` are equivalent. |
There was a problem hiding this comment.
Is this correct? With panic=abort, I assumed a settable panic handler and/or a backtrace would happen, whereas process::abort will not call a panic handler.
There was a problem hiding this comment.
Just tested this and it looks like you're right - I'd missed that. I'll change the wording and mentioned that process::abort skips the panic handler.
shepmaster
added
the
S-waiting-on-author
|
I've amended that description to mention the panic hook, I think this is correct now. |
|
@PIRH |
|
@bors: r+ rollup |
|
📌 Commit 28ef0d1 has been approved by |
Update docs for process::abort Remove a typo and explain the relationship to `panic!`. Part of #29370 r? @steveklabnik
|
☀️ Test successful - status-appveyor, status-travis |
Remove a typo and explain the relationship to
panic!.Part of #29370
r? @steveklabnik