Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE]: Try out 128bit SipHash for incr. comp. hashes. #45028

Closed

Conversation

michaelwoerister
Copy link
Member

This is just for performance testing on perf.rust-lang.org. It's not meant to be merged in this state.

@rust-highfive
Copy link
Collaborator

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@michaelwoerister
Copy link
Member Author

Btw, this contains a copy of @arthurprs excellent metrohash implementation (had to copy it because finish128 is not public). In my local tests this was the best performing hash function I found on crates.io.

@michaelwoerister
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Oct 4, 2017

⌛ Trying commit 85a12ea with merge 0ea9f24...

bors added a commit that referenced this pull request Oct 4, 2017
[DO NOT MERGE]: Try out 128bit SipHash for incr. comp. hashes.

This is just for performance testing on perf.rust-lang.org. It's not meant to be merged in this state.
@arthurprs
Copy link
Contributor

Thanks for the ping, I'm always interesting in these changes. The faster the merrier 😄

Can perf.rust-lang.org test unmerged PRs? That's really nice.

@bors
Copy link
Contributor

bors commented Oct 4, 2017

☀️ Test successful - status-travis
State: approved= try=True

@michaelwoerister
Copy link
Member Author

Closing, see follow-up here: #41215 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants