-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incr.comp.: Bring back output of -Zincremental-info. #45063
incr.comp.: Bring back output of -Zincremental-info. #45063
Conversation
@bors r+ |
📌 Commit b81c858 has been approved by |
⌛ Testing commit b81c858 with merge 4d30cd2187d4658321e5d79561994020c5c1c32c... |
💔 Test failed - status-appveyor |
The
|
wat? |
This PR also adds some statistical output for the dependency graph (example from regex crate):
|
@bors retry |
⌛ Testing commit b81c858 with merge 3a777929f67a1ae6fad57bc7f529449fc9f0377a... |
💔 Test failed - status-travis |
@bors retry
|
…r=nikomatsakis incr.comp.: Bring back output of -Zincremental-info. This got kind lost during the transition to red/green. I also switched back from `eprintln!()` to `println!()` since the former never actually produced any output. I suspect this has to do with `libterm` somehow monopolizing `stderr`. r? @nikomatsakis
☀️ Test successful - status-appveyor, status-travis |
incr.comp.: Use a set implementation optimized for small item counts for deduplicating read-edges. Many kinds of `DepNodes` will only ever have between zero and three edges originating from them (see e.g. #45063 (comment)) so let's try to avoid allocating a `HashSet` in those cases. r? @nikomatsakis
This got kind lost during the transition to red/green.
I also switched back from
eprintln!()
toprintln!()
since the former never actually produced any output. I suspect this has to do withlibterm
somehow monopolizingstderr
.r? @nikomatsakis