Fixes for beta #45986
Merged
Fixes for beta #45986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arielb1
commented
Nov 14, 2017
arielb1
commented
- fixes to MIR effectck #45785
- check::method - unify receivers before normalizing method signatures #45890
- check_unsafety: fix unused unsafe block duplication #45985
fixes to MIR effectck r? @eddyb beta-nominating because regression (MIR effectck is new)
check::method - unify receivers before normalizing method signatures Normalizing method signatures can unify inference variables, which can cause receiver unification to fail. Unify the receivers first to avoid that. Fixes rust-lang#36701. Fixes rust-lang#45801. Fixes rust-lang#45855. r? @eddyb beta-nominating because rust-lang#43880 made this ICE happen in more cases (the code in that issue ICEs post-rust-lang#43880 only, but the unit test here ICEs on all versions).
The duplicate error message is later removed by error message deduplication, but it still appears on beta and is still a bug
kennytm
added
the
S-waiting-on-review
|
This looks great to me, thanks! @bors: r+ p=1 I'm not sure how the commits were generated though in that they don't look like the usual cherry-picks, but the changes look like they line up at least |
|
📌 Commit 73bdf67 has been approved by |
|
@bors p=2 |
|
☀️ Test successful - status-appveyor, status-travis |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.