Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustbuild: Update LLVM and enable ThinLTO #46008

Merged
merged 2 commits into from
Nov 25, 2017
Merged

rustbuild: Update LLVM and enable ThinLTO #46008

merged 2 commits into from
Nov 25, 2017

Commits on Nov 24, 2017

  1. rustbuild: Update LLVM and enable ThinLTO 

    This commit updates LLVM to fix rust-lang#45511 (https://reviews.llvm.org/D39981) and
also reenables ThinLTO for libtest now that we shouldn't hit rust-lang#45768. This also
opportunistically enables ThinLTO for libstd which was previously blocked
(rust-lang#45661) on test failures related to debuginfo with a presumed cause of rust-lang#45511.

Closes rust-lang#45511
    @alexcrichton
    alexcrichton committed Nov 24, 2017
    Configuration menu
    Copy the full SHA
    47498de View commit details
    Browse the repository at this point in the history

  2. std: Flag Windows TLS dtor symbol as #[used] 

    Turns out ThinLTO was internalizing this symbol and eliminating it. Worse yet if
you compiled with LTO turns out no TLS destructors would run on Windows! The
`#[used]` annotation should be a more bulletproof implementation (in the face of
LTO) of preserving this symbol all the way through in LLVM and ensuring it makes
it all the way to the linker which will take care of it.
    @alexcrichton
    alexcrichton committed Nov 24, 2017
    Configuration menu
    Copy the full SHA
    95e9609 View commit details
    Browse the repository at this point in the history