Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Enable full backtraces #46222

Closed
wants to merge 1 commit into from

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Nov 23, 2017

No description provided.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@Zoxc
Copy link
Contributor Author

Zoxc commented Nov 23, 2017

@bors try

@bors
Copy link
Contributor

bors commented Nov 23, 2017

⌛ Trying commit 1f1c060 with merge 685bdd4...

bors added a commit that referenced this pull request Nov 23, 2017
DO NOT MERGE: Enable full backtraces
@kennytm kennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 23, 2017
@kennytm
Copy link
Member

kennytm commented Nov 23, 2017

The last time I tried (#45693), while the CI duration is more or less the same for Linux, macOS slowed down to close to the 3 hour limit. So I don't think this can be unconditionally enabled.

@bors
Copy link
Contributor

bors commented Nov 23, 2017

☀️ Test successful - status-travis
State: approved= try=True

@alexcrichton
Copy link
Member

What's the rationale for this? (no PR description, no documentation...) Why full instead of 1? Why set unconditionally in bootstrap.py with no option to turn it off?

@Zoxc
Copy link
Contributor Author

Zoxc commented Nov 24, 2017

I saw a heap corruption on Windows with backtraces enabled, so I wanted to see if that happened on CI too, but I guess try is Linux only and doesn't run tests now.

@kennytm
Copy link
Member

kennytm commented Nov 24, 2017

@Zoxc Is there an issue for this?

@Zoxc
Copy link
Contributor Author

Zoxc commented Nov 24, 2017

@kennytm There is one now: #46243

@Zoxc Zoxc closed this Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants