Stabilize const-calling existing const-fns in std #46287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
SimonSapin
force-pushed
the
stable-constness
branch
from
278bd25
to
6c5f53e
Compare
kennytm
added
the
S-waiting-on-review
|
@bors: r+ Thanks for pushing this through, @SimonSapin |
|
📌 Commit 6c5f53e has been approved by |
|
⌛ Testing commit 6c5f53e with merge dbc8d4b392fed320ba4455b2184ee42c9d9f2044... |
|
💔 Test failed - status-travis |
[00:12:31] In file included from /Users/travis/build/rust-lang/rust/src/llvm/lib/Support/ThreadPool.cpp:14:
[00:12:31] In file included from /Users/travis/build/rust-lang/rust/src/llvm/include/llvm/Support/ThreadPool.h:30:
[00:12:31] /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/future:1447:23: error: 'future_error' is unavailable: introduced in macOS 10.8
[00:12:31] future_error(make_error_code(future_errc::broken_promise))
[00:12:31] ^
[00:12:31] /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/future:502:63: note: 'future_error' has been explicitly marked unavailable here
[00:12:31] class _LIBCPP_EXCEPTION_ABI _LIBCPP_AVAILABILITY_FUTURE_ERROR future_error
[00:12:31] ^
[00:12:31] /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/future:1621:23: error: 'future_error' is unavailable: introduced in macOS 10.8
[00:12:31] future_error(make_error_code(future_errc::broken_promise))
[00:12:31] ^
[00:12:31] /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/future:502:63: note: 'future_error' has been explicitly marked unavailable here
[00:12:31] class _LIBCPP_EXCEPTION_ABI _LIBCPP_AVAILABILITY_FUTURE_ERROR future_error
[00:12:31] ^
[00:12:31] 2 errors generated.
[00:12:31] make[3]: *** [lib/Support/CMakeFiles/LLVMSupport.dir/ThreadPool.cpp.o] Error 1
[00:12:31] make[2]: *** [lib/Support/CMakeFiles/LLVMSupport.dir/all] Error 2Same error as #46290 (comment) |
|
@bors retry — travis-ci/travis-ci#8821 |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Nov 29, 2017
Stabilize const-calling existing const-fns in std Fixes rust-lang#46038
kennytm
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46038