-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustc_trans: don't write discriminants for uninhabited variants #46521
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @michaelwoerister (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@bors r+ |
📌 Commit 92345a1 has been approved by |
Test please @bors r- |
Fixes rust-lang#46519. Patch as suggested by eddyb: rust-lang#46519 (comment)
92345a1
to
d4fabb9
Compare
Added a test that I confirmed failing in Nightly with:
|
@bors r+ |
📌 Commit d4fabb9 has been approved by |
⌛ Testing commit d4fabb9 with merge fa46bca197025c8690a37eb63e29df1246aa529a... |
💔 Test failed - status-travis |
@bors retry
|
rustc_trans: don't write discriminants for uninhabited variants Fixes #46519. Patch as suggested by eddyb: #46519 (comment)
☀️ Test successful - status-appveyor, status-travis |
Just noticed this while reading through rust-lang#46521, which introduced this weird alignment.
rustc_trans: Fix indentation in trans_set_discr. Just noticed this while reading through #46521, which introduced this weird alignment.
Move tests r? `@petrochenkov` rust-lang#46521 -> enum-discriminant
Fixes #46519.
Patch as suggested by eddyb: #46519 (comment)