Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc_trans: don't write discriminants for uninhabited variants #46521

Merged
merged 1 commit into from
Dec 6, 2017

Conversation

SimonSapin
Copy link
Contributor

Fixes #46519.

Patch as suggested by eddyb: #46519 (comment)

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @michaelwoerister (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@eddyb
Copy link
Member

eddyb commented Dec 5, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Dec 5, 2017

📌 Commit 92345a1 has been approved by eddyb

@eddyb eddyb added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 5, 2017
@arielb1
Copy link
Contributor

arielb1 commented Dec 5, 2017

Test please

@bors r-

@SimonSapin
Copy link
Contributor Author

Added a test that I confirmed failing in Nightly with:

$ rustc +nightly ~/rust3/src/test/run-pass/issue-46519.rs --test -O            
zsh: floating point exception (core dumped)  rustc +nightly ~/rust3/src/test/run-pass/issue-46519.rs --test -O

@eddyb
Copy link
Member

eddyb commented Dec 5, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Dec 5, 2017

📌 Commit d4fabb9 has been approved by eddyb

@bors
Copy link
Contributor

bors commented Dec 6, 2017

⌛ Testing commit d4fabb9 with merge fa46bca197025c8690a37eb63e29df1246aa529a...

@bors
Copy link
Contributor

bors commented Dec 6, 2017

💔 Test failed - status-travis

@eddyb
Copy link
Member

eddyb commented Dec 6, 2017

@bors retry

  • some spurious Ruby AWS failure

@bors
Copy link
Contributor

bors commented Dec 6, 2017

⌛ Testing commit d4fabb9 with merge a62910b...

bors added a commit that referenced this pull request Dec 6, 2017
rustc_trans: don't write discriminants for uninhabited variants

Fixes #46519.

Patch as suggested by eddyb: #46519 (comment)
@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 6, 2017
@bors
Copy link
Contributor

bors commented Dec 6, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing a62910b to master...

@bors bors merged commit d4fabb9 into rust-lang:master Dec 6, 2017
@SimonSapin SimonSapin deleted the uninhabited-variants branch December 6, 2017 11:06
@michaelwoerister michaelwoerister added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Dec 7, 2017
emilio added a commit to emilio/rust that referenced this pull request Dec 10, 2017
Just noticed this while reading through rust-lang#46521, which introduced this weird
alignment.
bors added a commit that referenced this pull request Dec 11, 2017
rustc_trans: Fix indentation in trans_set_discr.

Just noticed this while reading through #46521, which introduced this weird
alignment.
@c410-f3r c410-f3r mentioned this pull request Nov 12, 2022
JohnTitor pushed a commit to JohnTitor/rust that referenced this pull request Nov 13, 2022
Move tests

r? `@petrochenkov`

rust-lang#46521 -> enum-discriminant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants