Allow feature-gate tests to live in ui/ and migrate most of the tests from compile-fail #46532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
kennytm
added
the
S-waiting-on-review
|
Nice! |
|
📌 Commit d80d4ad has been approved by |
kennytm
added
S-waiting-on-bors
|
🔒 Merge conflict |
kennytm
added
S-waiting-on-author
ui tests are the future, especially since the recent improvement where we have gained checking and requiring of //~ERROR comments. The tidy feature-gate test check is intended to be 50% an actual insurance that there is a check, and 50% to be a teacher that such checks are required. With this commit applied, newbies might interpret stuff wrongly and create tests that don't fail but succeed instead. This is not what feature gate tests are for though. Therefore, in a later step, when only ui tests are allowed to be feature gate tests, we will add checking to ensure that a file marked as gate test is actually required to be a compilation failure. Right now implementing such a check is a bit annoying as one needs to only do it when the compile-fail test is in the ui test suite :/.
Renames only in this commit, and obviously .stderr file additions.
We also rename some of the files to conform to the feature-gate-<feat_name>.rs pattern that is most common.
|
@bors delegate+ |
|
✌️ @est31 can now approve this pull request |
|
@bors r+ |
|
📌 Commit 6dba3e6 has been approved by |
kennytm
added
S-waiting-on-bors
|
@bors p=1 |
bors
added a commit
that referenced
this pull request
Dec 7, 2017
Allow feature-gate tests to live in ui/ and migrate most of the tests from compile-fail The PR consists of three commits: 1. change tidy to allow feature-gate tests to live in ui/ 2. migrate some feature gate tests to ui/ with renaming only 3. migrate some feature gate tests to ui/ with also removing `// gate-test-...` lines and renaming them to the standard `feature-gate-<feat-name>.rs` format.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR consists of three commits:
// gate-test-...lines and renaming them to the standardfeature-gate-<feat-name>.rsformat.