fix broken assertion in type_param #46722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nested generics (aka method generics) in trait methods don't have an *additional* Self parameter in their own type parameter list (they have a Self parameter in the parent generics), so don't try to check we're correctly adjusting for it. Fixes rust-lang#46568.
kennytm
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 2679944 has been approved by |
kennytm
added
S-waiting-on-bors
|
☀️ Test successful - status-appveyor, status-travis |
cuviper
added a commit
to cuviper/rust
that referenced
this pull request
May 8, 2023
This reverts rust-lang#46722, commit e0ab5d5. Since rust-lang#111167, commit 10b69dd, we are generating DWARF subprograms in a way that is meant to be more compatible with LLVM's expectations, so hopefully we don't need this workaround rewriting CUs anymore.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 18, 2023
Remove the ThinLTO CU hack This reverts rust-lang#46722, commit e0ab5d5. Since rust-lang#111167, commit 10b69dd, we are generating DWARF subprograms in a way that is meant to be more compatible with LLVM's expectations, so hopefully we don't need this workaround rewriting CUs anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested generics (aka method generics) in trait methods don't have an
additional Self parameter in their own type parameter list (they have
a Self parameter in the parent generics), so don't try to check we're
correctly adjusting for it.
Fixes #46568.
r? @eddyb