-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 5 pull requests #46904
Merged
Merged
Rollup of 5 pull requests #46904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GuillaumeGomez
commented
Dec 21, 2017
- Successful merges: syntax: Follow-up to the incorrect qpath recovery PR #46827, Fix some rustdoc warnings #46853, Use def span for associated function suggestions #46860, Fix sidebar on ios #46861, Ensure separate activations only occur for assignments to locals #46887
- Failed merges:
…nary and binary operators
syntax: Follow-up to the incorrect qpath recovery PR cc rust-lang#46788 Add tests checking that "priority" of qpath recovery is higher than priority of unary and binary operators Fix regressed parsing of paths with fn-like generic arguments r? @estebank
… r=QuietMisdreavus Fix some rustdoc warnings r? @QuietMisdreavus cc @steveklabnik
…henkov Use def span for associated function suggestions
…uietMisdreavus Fix sidebar on ios r? @QuietMisdreavus
…m-assignments-to-locals, r=arielb1 Ensure separate activations only occur for assignments to locals Ensure separate activations only occur for assignments to locals, not projections. Fix rust-lang#46746. (I didn't make a regression test because we do not really have a good way to directly express the case that we are trying to catch, because we cannot write MIR directly.)
Some changes occurred in HTML/CSS. |
@bors: r+ p=1 |
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
📌 Commit bdd3f5b has been approved by |
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.