Make the output of the column! macro 1 based #46977
Conversation
kennytm
added
S-waiting-on-review
bluss
added
the
relnotes
src/libstd/macros.rs
Outdated
| /// The expanded expression has type `u32` and is 1-based, so the first line | ||
| /// in each file evaluates to 1, the second to 2, etc. This is consistent | ||
| /// with error messages by common compilers or popular editors. | ||
| /// The returned column is not the invocation of the `line!` macro itself, |
There was a problem hiding this comment.
This should say the returned *line*.
There was a problem hiding this comment.
Since we are touching this line anyway, I find "not the invocation of the `line!` macro itself" a bit misleading, because it is totally possible and expected for the return value to be the line of the invocation of the line macro itself when not being called from another macro. It may be clearer as "not necessarily the line of the `line!` invocation itself".
(Okay to ignore this if you want, since it was that way before.)
|
I've fixed the pointed out mistake. General improvement of the docs is best done in a separate PR IMO. re-r? @dtolnay |
|
@bors r+ |
|
📌 Commit 6081989 has been approved by |
|
⌛ Testing commit 6081989 with merge cfdebb52f3018996c2d5cf9566019bb18607dc26... |
|
💔 Test failed - status-travis |
|
⌛ Testing commit 6081989 with merge 870b94f02d866df47ec5335f08a1348e5703448e... |
|
💔 Test failed - status-travis |
|
@bors retry |
|
☀️ Test successful - status-appveyor, status-travis |
Fixes #46868.
I didn't add any regression tests as the change already had to change tests inside the codebase.
r? @dtolnay