Minor cleanup for slice::Chunks and ChunksMut #47113
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dtolnay (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
sdroege
force-pushed
the
chunks-size-field
branch
from
2a17b1b
to
5ad4694
Compare
src/libcore/slice/mod.rs
Outdated
| @@ -348,9 +348,9 @@ impl<T> SliceExt for [T] { | |||
| } | |||
|
|
|||
| #[inline] | |||
| fn chunks(&self, size: usize) -> Chunks<T> { | |||
| fn chunks(&self, chunk_size: usize) -> Chunks<T> { | |||
| assert!(size != 0); | |||
There was a problem hiding this comment.
Indeed, thanks. Sorry for that!
sdroege
force-pushed
the
chunks-size-field
branch
from
5ad4694
to
cb8e011
Compare
Previously Chunks used size and ChunksMut used chunk_size
sdroege
force-pushed
the
chunks-size-field
branch
from
cb8e011
to
c096b3a
Compare
|
Also fixed another case of |
|
@bors r+ rollup |
|
📌 Commit c096b3a has been approved by |
Minor cleanup for slice::Chunks and ChunksMut This only renames the `size` field to `chunk_size` in one of them for consistency, and changes an assertion to check for != 0 instead of > 0.
rust-lang#47113 renamed the private size field to chunk_size for consistency.
This only renames the
sizefield tochunk_sizein one of them for consistency, and changes an assertion to check for != 0 instead of > 0.