Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some outdated LLVM-related code #47173

Merged
merged 3 commits into from
Jan 6, 2018
Merged

Remove some outdated LLVM-related code #47173

merged 3 commits into from
Jan 6, 2018

Conversation

dotdash
Copy link
Contributor

@dotdash dotdash commented Jan 4, 2018

Ticks two boxes on #46437

@dotdash
Remove outdated LLVMRustBuildLandingPad() wrapper
d7bbd30 
The function was added as a wrapper to handle compatibility with older
LLVM versions that we no longer support, so it can be removed.

Refs rust-lang#46437
@dotdash
Remove unused function LLVMRustGetValueContext()
493c29d 
Refs rust-lang#46437
@dotdash
Simplify LLVMRustModuleCost()
7e522b2
@rust-highfive
Copy link
Collaborator

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@michaelwoerister
Copy link
Member

Thanks, @dotdash!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 4, 2018

📌 Commit 7e522b2 has been approved by michaelwoerister

@alexcrichton alexcrichton added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 4, 2018
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 4, 2018
@steveklabnik
Rollup merge of rust-lang#47173 - dotdash:cleanup, r=michaelwoerister
1772715 
Remove some outdated LLVM-related code

Ticks two boxes on rust-lang#46437
@steveklabnik steveklabnik mentioned this pull request Jan 4, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Jan 4, 2018
@kennytm
Rollup merge of rust-lang#47173 - dotdash:cleanup, r=michaelwoerister
a4e4899 
Remove some outdated LLVM-related code

Ticks two boxes on rust-lang#46437
@kennytm kennytm mentioned this pull request Jan 4, 2018
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 6, 2018
@GuillaumeGomez
Rollup merge of rust-lang#47173 - dotdash:cleanup, r=michaelwoerister
21b9822 
Remove some outdated LLVM-related code

Ticks two boxes on rust-lang#46437
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 6, 2018
Merged
bors added a commit that referenced this pull request Jan 6, 2018
@bors
Auto merge of #47225 - GuillaumeGomez:rollup, r=GuillaumeGomez
8d370ec 
Rollup of 5 pull requests

- Successful merges: #46987, #47165, #47173, #47202, #47216
- Failed merges:
@bors bors merged commit 7e522b2 into rust-lang:master Jan 6, 2018
@dotdash dotdash deleted the cleanup branch January 31, 2018 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton Awaiting requested review from alexcrichton

Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dotdash @rust-highfive @michaelwoerister @bors @alexcrichton