-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix off-by-one error #47330
fix off-by-one error #47330
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Nice catch, thank you! @bors: r+ rollup |
📌 Commit 0e9dde9 has been approved by |
Maybe use an inclusive range to be more clear? |
@nixpulvis, you mean 0..10? |
Nope, though now that I'm playing with it it looks like it's experamental and kinda a mess imho, see #28237. Inclusive ranges (in this context) include the last element as well as the rest. |
I would however strongly encourage a change to |
This change is now incorrect. The documentation says:
The code now writes the numbers from zero through nine. You should add one to |
@varkor, you meant this? |
@varkor oh nice catch, I should have read the docs more carefully before suggesting |
Looks great @bmusin! Please go ahead and squash these commits and we will be good to merge! |
Squashed. |
Thanks! @bors: r+ rollup |
📌 Commit cee295e has been approved by |
fix off-by-one error Fixes rust-lang#47325.
fix off-by-one error Fixes rust-lang#47325.
Fixes #47325.