-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add documentation from doc(include) to analysis data #47496
Conversation
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
Should this have some kind of test? I don't know how to test it though. r=me once ci finishes. |
Before pushing, i had a quick look through the tests in |
I figured that might be the case :-/ @nrc are you aware of any testing for save-analysis? |
There are a couple of smoke tests in run-make/save-analysis or something similar which basically only test that the compiler doesn't crash. However, it is useful to add things like this to one of those tests. |
Ping from triage @QuietMisdreavus ! We haven't heard from you in a week; will you be able to address the recent comments soon? |
Whoops, forgot about this one. I guess the way forward would be to just add something with |
@estebank ping from triage! |
@bors r+ rollup |
📌 Commit 5a350c1 has been approved by |
…estebank add documentation from doc(include) to analysis data cc rust-lang#44732 Currently save-analysis only loads docs from plain doc comments and doc attributes. Since `#[doc(include="filename.md")]` doesn't create a plain doc attribute when it loads the file, we need to be sure to pick up this info for the analysis data.
cc #44732
Currently save-analysis only loads docs from plain doc comments and doc attributes. Since
#[doc(include="filename.md")]
doesn't create a plain doc attribute when it loads the file, we need to be sure to pick up this info for the analysis data.