Make non-found module name optional #47498
Conversation
No longer uses a magic string for missing or root module.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
r? @jseyfried or @petrochenkov |
| format!("no `{}` in `{}`{}", ident, module_str, lev_suggestion) | ||
| } else { | ||
| format!("no `{}` in the root{}", ident, lev_suggestion) |
There was a problem hiding this comment.
Could you add a test for this?
There was a problem hiding this comment.
IIRC, there was an issue about this ??? but I can't find it right away.
There was a problem hiding this comment.
Ah, ok, this is not a new message, just refactoring.
|
@bors r+ rollup |
|
📌 Commit 1dcfd14 has been approved by |
kennytm
added
the
S-waiting-on-bors
…etrochenkov Make non-found module name optional No longer uses a magic string for missing or root module.
…etrochenkov Make non-found module name optional No longer uses a magic string for missing or root module.
No longer uses a magic string for missing or root module.