Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead code #47842

Merged
merged 1 commit into from
Feb 3, 2018
Merged

Remove dead code #47842

merged 1 commit into from
Feb 3, 2018

Conversation

Manishearth
Copy link
Member

The Clone impl makes the lint ignore the type.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 29, 2018
@nagisa
Copy link
Member

nagisa commented Jan 29, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Jan 29, 2018

📌 Commit 1e9fef8 has been approved by nagisa

@kennytm kennytm mentioned this pull request Jan 29, 2018
Closed
@bors
Copy link
Contributor

bors commented Jan 30, 2018

☔ The latest upstream changes (presumably #47870) made this pull request unmergeable. Please resolve the merge conflicts.

@nikomatsakis nikomatsakis added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2018
@Manishearth
Copy link
Member Author

@bors r=nagisa

@bors
Copy link
Contributor

bors commented Feb 2, 2018

📌 Commit c785013 has been approved by nagisa

@kennytm kennytm mentioned this pull request Feb 2, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Feb 2, 2018
@kennytm
Rollup merge of rust-lang#47842 - Manishearth:dead-code, r=nagisa Rem…
a671944 
…ove dead code The Clone impl makes the lint ignore the type.
@Mark-Simulacrum
Copy link
Member

@bors rollup

bors added a commit that referenced this pull request Feb 3, 2018
@bors
Auto merge of #47962 - kennytm:rollup, r=kennytm
8d04b8f 
Rollup of 10 pull requests

- Successful merges: #46156, #47829, #47842, #47898, #47914, #47916, #47919, #47942, #47951, #47973
- Failed merges: #47753
@bors bors merged commit c785013 into rust-lang:master Feb 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Manishearth @rust-highfive @nagisa @bors @Mark-Simulacrum @kennytm @nikomatsakis