Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebased refactorings for Chalk #47861

Merged
merged 22 commits into from
Mar 2, 2018
Merged

Rebased refactorings for Chalk #47861

merged 22 commits into from
Mar 2, 2018

Commits on Mar 1, 2018

  1. introduce Universe struct

    @nikomatsakis @sgrif
    nikomatsakis authored and sgrif committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    803bd76 View commit details
    Browse the repository at this point in the history

  2. add some comments to Obligation

    @nikomatsakis @sgrif
    nikomatsakis authored and sgrif committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    e7efce2 View commit details
    Browse the repository at this point in the history

  3. introduce UniverseIndex into ParamEnv 

    Always using root environment for now.
    @nikomatsakis @sgrif
    nikomatsakis authored and sgrif committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    d4df52c View commit details
    Browse the repository at this point in the history

  4. use {} for Known variant just for more parity

    @nikomatsakis @sgrif
    nikomatsakis authored and sgrif committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    d516b26 View commit details
    Browse the repository at this point in the history

  5. make Default Copy and Clone

    @nikomatsakis @sgrif
    nikomatsakis authored and sgrif committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    7112d65 View commit details
    Browse the repository at this point in the history

  6. kill custom type inference defaults (these don't really work anyway)

    @nikomatsakis @sgrif
    nikomatsakis authored and sgrif committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    047a8d0 View commit details
    Browse the repository at this point in the history

  7. kill supporting code from type-variable defaults 

    This was all unused anyway.
    @nikomatsakis @sgrif
    nikomatsakis authored and sgrif committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    b680b12 View commit details
    Browse the repository at this point in the history

  8. obtain UnificationTable and snapshot_vec from ena instead 

    The ena version has an improved interface. I suspect
`librustc_data_structures` should start migrating out to crates.io in
general.
    @nikomatsakis @sgrif
    nikomatsakis authored and sgrif committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    c7953bb View commit details
    Browse the repository at this point in the history

  9. store type values in the unification table directly

    @nikomatsakis @sgrif
    nikomatsakis authored and sgrif committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    57a593f View commit details
    Browse the repository at this point in the history

  10. correct subtle bug in the type variable code

    @nikomatsakis @sgrif
    nikomatsakis authored and sgrif committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    ccd92c2 View commit details
    Browse the repository at this point in the history

  11. have probe() return TypeVariableValue

    @nikomatsakis @sgrif
    nikomatsakis authored and sgrif committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    69fe43c View commit details
    Browse the repository at this point in the history

  12. remove unnecessary clause propagating divergence 

    This should not be needed: the new variable will be related to the old
ones, so if they are constrained, so is the new variable; if they are
not, and hence default to diverging, so will the new variable.
    @nikomatsakis @sgrif
    nikomatsakis authored and sgrif committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    44d9929 View commit details
    Browse the repository at this point in the history

  13. add universes to type inference variables

    @nikomatsakis @sgrif
    nikomatsakis authored and sgrif committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    13efaf0 View commit details
    Browse the repository at this point in the history

  14. change skolemizations to use universe index

    @nikomatsakis @sgrif
    nikomatsakis authored and sgrif committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    35e78b5 View commit details
    Browse the repository at this point in the history

  15. fix tidy error

    @nikomatsakis @sgrif
    nikomatsakis authored and sgrif committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    a985634 View commit details
    Browse the repository at this point in the history

  16. fix tests in librustc_driver

    @nikomatsakis @sgrif
    nikomatsakis authored and sgrif committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    17df455 View commit details
    Browse the repository at this point in the history

  17. change skolemizations to use universe index 

    These changes were meant to be in
2b18d8fe9dc05415a8e6b7cadf879c7f7ebe020a (rebased from
12a2305), but I messed up the rebase a
bit as the file had been moved.
    @sgrif
    sgrif committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    755bdaa View commit details
    Browse the repository at this point in the history

  18. Remove dead code 

    These modules were replaced with re-exports from ena
    @sgrif
    sgrif committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    c301838 View commit details
    Browse the repository at this point in the history

  19. Re-add some removed uses of Kind 

    Additional uses of this item were added to these files in rust-lang#45701 and rust-lang#46479
    @sgrif
    sgrif committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    4fb201d View commit details
    Browse the repository at this point in the history

  20. Fix bad rebase

    @sgrif
    sgrif committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    e9eb1a6 View commit details
    Browse the repository at this point in the history

  21. Fix breakage in rustdoc

    @sgrif
    sgrif committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    a6d8533 View commit details
    Browse the repository at this point in the history

  22. Bump ena

    @sgrif
    sgrif committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    fec4d3b View commit details
    Browse the repository at this point in the history